Fix <ReferenceArrayField /> throw error when its value is not an array #7899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
changed the title
djhi
reviewed
Jul 6, 2022
packages/ra-core/src/controller/field/useReferenceArrayFieldController.ts
Outdated
Show resolved
Hide resolved
djhi
requested changes
Jul 6, 2022
packages/ra-core/src/controller/field/useReferenceArrayFieldController.ts
Outdated
Show resolved
Hide resolved
…ntroller.ts Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
djhi
approved these changes
Jul 6, 2022
|
Thanks! |
…dhav/react-admin into reference-array-field-bug-fix
|
Sorry! should pass now |
antoinefricker
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if
record.sourceis not an array it throwsids.map is not a functionerror. i think it should be same behavior as "no records matched" and use show empty array in this case.it is possible same apps have different data type of a field and not always an array.
but it shouldn't crash entire list component because of that