Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <ReferenceArrayField /> throw error when its value is not an array #7899

Merged
merged 7 commits into from
Jul 6, 2022
Merged

Fix <ReferenceArrayField /> throw error when its value is not an array #7899

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e387988
do array check to avoid ids.map is not a function
shreyas-jadhav Jun 26, 2022
4332896
Merge branch 'marmelab:master' into reference-array-field-bug-fix
shreyas-jadhav Jul 6, 2022
be772b4
added console warning
shreyas-jadhav Jul 6, 2022
744a946
Update packages/ra-core/src/controller/field/useReferenceArrayFieldCo…
shreyas-jadhav Jul 6, 2022
8946601
use emptyArray variable which was also used before
shreyas-jadhav Jul 6, 2022
6ce652c
Merge branch 'reference-array-field-bug-fix' of github.com:shreyas-ja…
shreyas-jadhav Jul 6, 2022
03cd3d4
added source in dependency
shreyas-jadhav Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/ra-core/src/controller/field/useReferenceArrayFieldController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import get from 'lodash/get';

import { useMemo } from 'react';
import { RaRecord, SortPayload } from '../../types';
import { useGetManyAggregate } from '../../dataProvider';
import { ListControllerResult, useList } from '../list';
Expand Down Expand Up @@ -56,7 +56,14 @@ export const useReferenceArrayFieldController = (
source,
} = props;
const notify = useNotify();
const ids = get(record, source) || emptyArray;
const value = get(record, source);

const ids = useMemo(() => {
if (Array.isArray(value)) return value;
console.warn(`Value of field '${source}' is not an array.`);
return emptyArray;
}, [value, source]);

const { data, error, isLoading, isFetching, refetch } = useGetManyAggregate(
reference,
{ ids },
Expand Down