Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use auth provider in docs #7927

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

sunil-sharma-999
Copy link
Contributor

@sunil-sharma-999 sunil-sharma-999 commented Jul 5, 2022

Replacing useAuthProvider.getIdentity() to authProvider.getIdentity() in docs.

fix eslint warnings
- Assign object to a variable before exporting as module default
- Assign arrow function to a variable before exporting as module default
Replaced useAuthProvider.getIdentity() to authProvider.getIdentity()
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙂

@slax57 slax57 added this to the 4.2.1 milestone Jul 5, 2022
@slax57 slax57 added the RFR Ready For Review label Jul 5, 2022
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we agree to use named exports in #7926?

@sunil-sharma-999
Copy link
Contributor Author

@djhi

Yeah but hadn't agreed when i requested a pull request for this one. Planning on making another pull request for Tutorial.md after I make changes to working example of examples/tutorial

@djhi djhi merged commit 3f7ec50 into marmelab:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants