Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add useInfiniteGetList hook #8063

Merged
merged 10 commits into from
Aug 31, 2022
Merged

Add useInfiniteGetList hook #8063

merged 10 commits into from
Aug 31, 2022

Conversation

arimet
Copy link
Contributor

@arimet arimet commented Aug 10, 2022 •
edited by fzaninotto

useInfinite2.mp4
  • Add types
  • See for export component in story file
  • Use story component for unit test
  • Add documentation

@arimet arimet added the WIP Work In Progress label Aug 10, 2022
@arimet arimet added RFR Ready For Review and removed WIP Work In Progress labels Aug 12, 2022
@arimet arimet changed the title [WIP] Add useInfiniteGetList hook [DNM] Add useInfiniteGetList hook Aug 12, 2022
@slax57 slax57 added the DNM label Aug 18, 2022
slax57
slax57 requested changes Aug 18, 2022
View reviewed changes
packages/ra-core/src/dataProvider/useInfiniteGetList.stories.tsx Outdated Show resolved Hide resolved
packages/ra-core/src/dataProvider/useInfiniteGetList.stories.tsx Outdated Show resolved Hide resolved
packages/ra-core/src/dataProvider/useInfiniteGetList.spec.tsx Outdated Show resolved Hide resolved
packages/ra-core/src/dataProvider/useInfiniteGetList.ts Outdated Show resolved Hide resolved
packages/ra-core/src/dataProvider/useInfiniteGetList.ts Outdated Show resolved Hide resolved
packages/ra-core/src/dataProvider/useInfiniteGetList.ts Outdated Show resolved Hide resolved
packages/ra-core/src/dataProvider/useInfiniteGetList.ts Outdated Show resolved Hide resolved
packages/ra-core/src/dataProvider/useInfiniteGetList.ts Outdated Show resolved Hide resolved
packages/ra-core/src/types.ts Outdated Show resolved Hide resolved
slax57
slax57 requested changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, gj! 🙂

packages/ra-core/src/dataProvider/useInfiniteGetList.ts Outdated Show resolved Hide resolved
@slax57 slax57 requested a review from fzaninotto August 29, 2022 15:14
@fzaninotto fzaninotto changed the base branch from master to next August 30, 2022 09:04
@fzaninotto fzaninotto removed the DNM label Aug 30, 2022
@fzaninotto fzaninotto changed the title [DNM] Add useInfiniteGetList hook Add useInfiniteGetList hook Aug 30, 2022
@fzaninotto fzaninotto added this to the 4.4.0 milestone Aug 30, 2022
@slax57 slax57 merged commit 4463c94 into next Aug 31, 2022
@slax57 slax57 deleted the useInfiniteGetList branch August 31, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arimet @fzaninotto @slax57