Fix RadioButtonGroupInput inside ReferenceInput when reference ids are numbers
#8229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
approved these changes
Oct 4, 2022
fzaninotto
changed the title
useReferenceInputController all choices merge in case id is not a stringRadioButtonGroupInput inside ReferenceInput when reference ids are numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: to merge the possible choices with the current choice,
useReferenceInputControllerchecks if the current value is already in the possible values or not (https://github.com/marmelab/react-admin/blob/master/packages/ra-core/src/controller/input/useReferenceInputController.ts#L125).This check only works if
idis of type string, because we check it against the current value coming straight from the form (with RHF'suseWatch).In the
/story/ra-ui-materialui-input-referenceinput--with-radio-button-group-inputstory, we use ids that are number, which causes the merge to fail.Solution: we should compare it with the id of the reference record fetched with
useReference, which should be of the matching typeAlternatives:
===with==(but I was unsure if this could have undesired side effects)This PR supersedes #8214