Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format and parse on AutocompleteInput and SelectInput #8237

Merged
merged 5 commits into from
Oct 5, 2022
Merged

Fix format and parse on AutocompleteInput and SelectInput #8237

merged 5 commits into from
Oct 5, 2022

Conversation

byymster
Copy link
Contributor

@byymster byymster commented Oct 5, 2022

Fix AutocompleteInput - Format and Parse doesn't work

Right now there's no way to use format and parse in AutocompleteInput (and AutocompleteArrayInput) because of ordering logical operations.

@byymster
Fix AutocompleteInput (Format and Parse)
1d8eb93 
## Fix AutocompleteInput - Format and Parse doesn't work
@WiXSL WiXSL added the RFR Ready For Review label Oct 5, 2022
WiXSL
WiXSL suggested changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@WiXSL WiXSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
Could you fix the typecheck warning?

@byymster
Copy link
Contributor Author

byymster commented Oct 5, 2022 •
edited
Loading

@WiXSL done. should be good.
Sorry I did change in Github's web and there no linters.

@fzaninotto
Copy link
Member

Great collaboration, good to go!

@fzaninotto fzaninotto merged commit 8f6b880 into marmelab:master Oct 5, 2022
@fzaninotto fzaninotto added this to the 4.4.1 milestone Oct 5, 2022
@fzaninotto
Copy link
Member

Thanks for the patch.

@fzaninotto fzaninotto changed the title Fix AutocompleteInput (Format and Parse) Fix format and parse on AutocompleteInput and SelectInput Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@WiXSL WiXSL WiXSL approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@byymster @fzaninotto @WiXSL