Fix redirectTo returned by useEditController
#8243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what bug this fixes. Could you please add a unit test? |
|
If you want to use the redirect from |
slax57
approved these changes
Oct 7, 2022
|
Seems good to me! I'll just wait on François' approval before merging |
fzaninotto
approved these changes
Oct 7, 2022
| @@ -220,7 +220,7 @@ export const useEditController = < | |||
| isLoading, | |||
| mutationMode, | |||
| record, | |||
| redirect: DefaultRedirect, | |||
| redirect: redirectTo, | |||
There was a problem hiding this comment.
This context variable isn't used anywhere in our code - I think it's a leftover from v3. I'll validate the PR, but I think we should ultimately mark it as deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useEditControllershould return the redirectTo used to redirect (if any) or the default, just likeuseCreateControllerdoes it, not the default