Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <BulkDeleteButton> doesn't clear selection when used inside <ReferenceManyField> #8358

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Fix <BulkDeleteButton> doesn't clear selection when used inside <ReferenceManyField> #8358

merged 2 commits into from
Nov 7, 2022

Conversation

fzaninotto
Copy link
Member

Closes #8328

@fzaninotto fzaninotto added the RFR Ready For Review label Nov 4, 2022
@fzaninotto fzaninotto changed the title Fix BulkdDeleteButton doesn't clear selection when used inside ReferenceManyField Fix <BulkDeleteButton> doesn't clear selection when used inside <ReferenceManyField> Nov 4, 2022
WiXSL
WiXSL suggested changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@WiXSL WiXSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is in conflict

@fzaninotto
Copy link
Member Author

fixed conflict

@WiXSL WiXSL merged commit 214a941 into master Nov 7, 2022
@WiXSL WiXSL deleted the fix-bulkdelete-in-referencemanyfield branch November 7, 2022 11:59
@WiXSL WiXSL added this to the 4.5.1 milestone Nov 7, 2022
@fzaninotto fzaninotto mentioned this pull request Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WiXSL WiXSL WiXSL approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.5.1
Development

Successfully merging this pull request may close these issues.

BulkDeleteButton not clearing selected state in ReferenceManyField
2 participants
@fzaninotto @WiXSL