-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignoring international numbers on PhoneNumberTextField #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good |
PaloSatala
approved these changes
Jun 12, 2023
renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Jul 7, 2023
….5" (#450) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [marmelroy/PhoneNumberKit](https://togithub.com/marmelroy/PhoneNumberKit) | minor | `from: "3.4.0"` -> `from: "3.6.5"` | --- ### Release Notes <details> <summary>marmelroy/PhoneNumberKit (marmelroy/PhoneNumberKit)</summary> ### [`v3.6.5`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.6.5) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.6.4...3.6.5) #### What's Changed - Fix [#​670](https://togithub.com/marmelroy/PhoneNumberKit/issues/670) - Infinite loop on clearButtonRect by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#671 **Full Changelog**: marmelroy/PhoneNumberKit@3.6.4...3.6.5 ### [`v3.6.4`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.6.4) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.6.3...3.6.4) #### What's Changed - Stop using NSObject (fix [#​634](https://togithub.com/marmelroy/PhoneNumberKit/issues/634)) by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#665 - Update README.md by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#666 - Enhancement: Added Insets Support for PhoneNumberTextField by [@​MussaCharles](https://togithub.com/MussaCharles) in [marmelroy/PhoneNumberKit#669 #### New Contributors - [@​MussaCharles](https://togithub.com/MussaCharles) made their first contribution in [marmelroy/PhoneNumberKit#669 **Full Changelog**: marmelroy/PhoneNumberKit@3.6.3...3.6.4 ### [`v3.6.3`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.6.3) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.6.2...3.6.3) #### What's Changed - Updated metadata to version metadata/8.13.14 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#658 - Reverted PR [#​652](https://togithub.com/marmelroy/PhoneNumberKit/issues/652) with improved logic by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#661 - Updated metadata to version metadata/8.13.15 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#663 - Added tests to PR by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#664 **Full Changelog**: marmelroy/PhoneNumberKit@3.6.1...3.6.3 ### [`v3.6.2`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.6.2) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.6.1...3.6.2) #### What's Changed - Updated metadata to version metadata/8.13.14 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#658 - Reverted PR [#​652](https://togithub.com/marmelroy/PhoneNumberKit/issues/652) with improved logic by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#661 **Full Changelog**: marmelroy/PhoneNumberKit@3.6.1...3.6.2 ### [`v3.6.1`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.6.1) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.6.0...3.6.1) #### What's Changed - Ignoring international numbers on PhoneNumberTextField by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#654 **Full Changelog**: marmelroy/PhoneNumberKit@3.6.0...3.6.1 ### [`v3.6.0`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.6.0) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.5.10...3.6.0) #### What's Changed - Updated metadata to version metadata/8.13.12 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#645 - Updated metadata to version metadata/8.13.13 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#650 - Removes the guessing game by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#652 **Full Changelog**: marmelroy/PhoneNumberKit@3.5.10...3.6.0 ### [`v3.5.10`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.5.10) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.5.9...3.5.10) #### What's Changed - Fix ambiguous phone number detection by [@​cosmer-work](https://togithub.com/cosmer-work) in [marmelroy/PhoneNumberKit#642 #### New Contributors - [@​cosmer-work](https://togithub.com/cosmer-work) made their first contribution in [marmelroy/PhoneNumberKit#642 **Full Changelog**: marmelroy/PhoneNumberKit@3.5.9...3.5.10 ### [`v3.5.9`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.5.9) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.5.8...3.5.9) #### What's Changed - Updated metadata to version metadata/8.13.8 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#617 - Updated metadata to version metadata/8.13.9 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#624 - Alternate way to load contents of a file in a Data object by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#620 - Updated metadata to version metadata/8.13.10 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#631 - Updated metadata to version metadata/8.13.11 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#636 **Full Changelog**: marmelroy/PhoneNumberKit@3.5.8...3.5.9 ### [`v3.5.8`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.5.8) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.5.7...3.5.8) #### What's Changed - Updated metadata to version metadata/8.13.7 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#608 - ensure default country code is capitalized by [@​mmdock](https://togithub.com/mmdock) in [marmelroy/PhoneNumberKit#612 #### New Contributors - [@​mmdock](https://togithub.com/mmdock) made their first contribution in [marmelroy/PhoneNumberKit#612 **Full Changelog**: marmelroy/PhoneNumberKit@3.5.7...3.5.8 ### [`v3.5.7`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.5.7) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.5.6...3.5.7) #### What's Changed - Updated metadata to version metadata/8.13.6 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#605 - Increment Swift version by [@​Juantri94](https://togithub.com/Juantri94) in [marmelroy/PhoneNumberKit#606 #### New Contributors - [@​Juantri94](https://togithub.com/Juantri94) made their first contribution in [marmelroy/PhoneNumberKit#606 **Full Changelog**: marmelroy/PhoneNumberKit@3.5.6...3.5.7 ### [`v3.5.6`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.5.6) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.5.5...3.5.6) #### What's Changed - Revert "Fix country picker by id ([#​601](https://togithub.com/marmelroy/PhoneNumberKit/issues/601))" by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#603 - Updated metadata to version metadata/8.13.5 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#604 **Full Changelog**: marmelroy/PhoneNumberKit@3.5.5...3.5.6 ### [`v3.5.5`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.5.5) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.5.4...3.5.5) #### What's Changed - Only change default region if the withFlag is true by [@​otusweb](https://togithub.com/otusweb) in [marmelroy/PhoneNumberKit#593 - Fix country picker by id for KZ, Canada, AX and other by [@​4taras4](https://togithub.com/4taras4) in [marmelroy/PhoneNumberKit#601 #### New Contributors - [@​otusweb](https://togithub.com/otusweb) made their first contribution in [marmelroy/PhoneNumberKit#593 - [@​4taras4](https://togithub.com/4taras4) made their first contribution in [marmelroy/PhoneNumberKit#601 **Full Changelog**: marmelroy/PhoneNumberKit@3.5.4...3.5.5 ### [`v3.5.4`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.5.4) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.5.3...3.5.4) #### What's Changed - Add missing text field delegate method by [@​aniastrzezek](https://togithub.com/aniastrzezek) in [marmelroy/PhoneNumberKit#592 - Updated metadata to version metadata/8.13.4 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#594 #### New Contributors - [@​aniastrzezek](https://togithub.com/aniastrzezek) made their first contribution in [marmelroy/PhoneNumberKit#592 **Full Changelog**: marmelroy/PhoneNumberKit@3.5.3...3.5.4 ### [`v3.5.3`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.5.3) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.5.2...3.5.3) #### What's Changed - Updated metadata to version metadata/8.13.3 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#590 - Add Equatable conformance for PhoneNumberError by [@​idrougge](https://togithub.com/idrougge) in [marmelroy/PhoneNumberKit#591 **Full Changelog**: marmelroy/PhoneNumberKit@3.5.2...3.5.3 ### [`v3.5.2`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.5.2) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.5.1...3.5.2) #### What's Changed - Updated metadata to version metadata/8.13.2 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#589 **Full Changelog**: marmelroy/PhoneNumberKit@3.5.1...3.5.2 ### [`v3.5.1`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.5.1) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.5.0...3.5.1) #### What's Changed - Updated metadata to version metadata/8.13.1 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#586 **Full Changelog**: marmelroy/PhoneNumberKit@3.5.0...3.5.1 ### [`v3.5.0`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.5.0) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.4.10...3.5.0) #### What's Changed - Updated metadata to version metadata/8.12.57 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#576 - Fix macCatalyst OS bug if language is set to Korean by [@​jackyabcde](https://togithub.com/jackyabcde) in [marmelroy/PhoneNumberKit#578 - Fix minor "dispaly" typo by [@​gsbernstein](https://togithub.com/gsbernstein) in [marmelroy/PhoneNumberKit#580 - Updated metadata to version metadata/8.13.0 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#582 - Introducing the new error `ambiguousNumber` by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#583 #### New Contributors - [@​jackyabcde](https://togithub.com/jackyabcde) made their first contribution in [marmelroy/PhoneNumberKit#578 - [@​gsbernstein](https://togithub.com/gsbernstein) made their first contribution in [marmelroy/PhoneNumberKit#580 **Full Changelog**: marmelroy/PhoneNumberKit@3.4.10...3.5.0 ### [`v3.4.10`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.4.10) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.4.9...3.4.10) #### What's Changed - Updated metadata to version metadata/8.12.56 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#572 - Change references to ISO 639 language code into ISO 3166 region code by [@​idrougge](https://togithub.com/idrougge) in [marmelroy/PhoneNumberKit#571 - Update flags for countries with the same international code by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#563 #### New Contributors - [@​idrougge](https://togithub.com/idrougge) made their first contribution in [marmelroy/PhoneNumberKit#571 **Full Changelog**: marmelroy/PhoneNumberKit@3.4.9...3.4.10 ### [`v3.4.9`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.4.9) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.4.8...3.4.9) #### What's Changed - Updated metadata to version metadata/8.12.55 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#568 **Full Changelog**: marmelroy/PhoneNumberKit@3.4.8...3.4.9 ### [`v3.4.8`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.4.8) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.4.7...3.4.8) #### What's Changed - Fix [#​557](https://togithub.com/marmelroy/PhoneNumberKit/issues/557) - Package not compiling for tvOS by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#561 - Revert [#​550](https://togithub.com/marmelroy/PhoneNumberKit/issues/550) due issues with other countries by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#562 **Full Changelog**: marmelroy/PhoneNumberKit@3.4.7...3.4.8 ### [`v3.4.7`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.4.7) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.4.6...3.4.7) #### What's Changed - Updated metadata to version metadata/8.12.54 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#556 **Full Changelog**: marmelroy/PhoneNumberKit@3.4.6...3.4.7 ### [`v3.4.6`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.4.6) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.4.5...3.4.6) #### What's Changed - Fix [#​451](https://togithub.com/marmelroy/PhoneNumberKit/issues/451) no flag change for different regionCode by [@​MaxZheleznyy](https://togithub.com/MaxZheleznyy) in [marmelroy/PhoneNumberKit#550 - Falling back default region to Locale if CNContactsUserDefaults is not available by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#551 - Updated metadata to version metadata/8.12.53 by [@​github-actions](https://togithub.com/github-actions) in [marmelroy/PhoneNumberKit#555 #### New Contributors - [@​github-actions](https://togithub.com/github-actions) made their first contribution in [marmelroy/PhoneNumberKit#555 **Full Changelog**: marmelroy/PhoneNumberKit@3.4.5...3.4.6 ### [`v3.4.5`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.4.5) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.4.4...3.4.5) #### What's Changed - Updated metadata according to v8.12.52 by [@​petermolnar-dev](https://togithub.com/petermolnar-dev) in [marmelroy/PhoneNumberKit#545 **Full Changelog**: marmelroy/PhoneNumberKit@3.4.4...3.4.5 ### [`v3.4.4`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.4.4) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.4.3...3.4.4) #### What's Changed - Normalizes the way of getting metadata from MetadataManager by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#542 **Full Changelog**: marmelroy/PhoneNumberKit@3.4.3...3.4.4 ### [`v3.4.3`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.4.3) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.4.2...3.4.3) #### What's Changed - Simplified default region code discovery by [@​petermolnar-dev](https://togithub.com/petermolnar-dev) in [marmelroy/PhoneNumberKit#538 - Updated metadata according to 8.12.51. by [@​petermolnar-dev](https://togithub.com/petermolnar-dev) in [marmelroy/PhoneNumberKit#537 **Full Changelog**: marmelroy/PhoneNumberKit@3.4.2...3.4.3 ### [`v3.4.2`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.4.2) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.4.1...3.4.2) #### What's Changed - Fix bundle search path by [@​vladyslavsosiuk](https://togithub.com/vladyslavsosiuk) in [marmelroy/PhoneNumberKit#531 - Updated metadata and related unit-tests according to the v8.12.50 by [@​petermolnar-dev](https://togithub.com/petermolnar-dev) in [marmelroy/PhoneNumberKit#534 - Fix [#​249](https://togithub.com/marmelroy/PhoneNumberKit/issues/249): Potential thread explosion by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#535 #### New Contributors - [@​vladyslavsosiuk](https://togithub.com/vladyslavsosiuk) made their first contribution in [marmelroy/PhoneNumberKit#531 - [@​petermolnar-dev](https://togithub.com/petermolnar-dev) made their first contribution in [marmelroy/PhoneNumberKit#534 **Full Changelog**: marmelroy/PhoneNumberKit@3.4.1...3.4.2 ### [`v3.4.1`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.4.1) [Compare Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.4.0...3.4.1) #### What's Changed - Makes RegexManager thread-safe by [@​bguidolim](https://togithub.com/bguidolim) in [marmelroy/PhoneNumberKit#529 **Full Changelog**: marmelroy/PhoneNumberKit@3.4.0...3.4.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cgrindel/rules_swift_package_manager). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMiIsInVwZGF0ZWRJblZlciI6IjM1LjE0NC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #653