Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for VS Code < 1.36 #79

Closed
yhatt opened this issue Sep 25, 2019 · 0 comments · Fixed by #91
Closed

Drop support for VS Code < 1.36 #79

yhatt opened this issue Sep 25, 2019 · 0 comments · Fixed by #91

Comments

@yhatt
Copy link
Member

yhatt commented Sep 25, 2019

We are considering to drop support for VS Code 1.31-1.35, that are using Electron which is required polyfill to render Marp preview.

We must leave ugly logics to apply polyfill for the correct preview in old versions. (e.g. #8, #19) In addition, The least version 1.31 cannot use auto fix command in Diagnostic API.

// act.isPreferred = true // TODO: Require VS Code >= v1.32

Thus, it's hard to maintain old compatibility while using features for the recent version. VS Code has auto-updation into the latest version, and we can't think that there are stuck users in the previous version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant