Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview of slides do not scale properly on linux #8

Closed
tosaba opened this issue Feb 21, 2019 · 9 comments · Fixed by #19
Closed

preview of slides do not scale properly on linux #8

tosaba opened this issue Feb 21, 2019 · 9 comments · Fixed by #19
Labels
bug Something isn't working

Comments

@tosaba
Copy link

tosaba commented Feb 21, 2019

having marp-cli integrated into vscode is really great, I just noticed that in the latest version, the slides do not scale properly in the preview panel

Version: 1.31.1
Commit: 1b8e8302e405050205e69b59abb3559592bb9e60
Date: 2019-02-12T02:19:29.629Z
Electron: 3.1.2
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Linux x64 4.15.0-45-generic

image

@yhatt
Copy link
Member

yhatt commented Feb 22, 2019

I have never seen this scene in Windows and macOS. I'm going to start testing in Linux. Would you have a minimum Markdown to reproduce this?

I had battled against the scaling bug in last year. (marp-team/marpit#35, marp-team/marp-cli#15) VSCode uses the old Chromium 66, and it revives me an old headache. 😣

@tosaba
Copy link
Author

tosaba commented Feb 22, 2019

Here is the minimum example. I also tested it with all my markdown related extensions being deactivated, but they don't interfere (except markdown all in one #9)

---
marp: true
---

# header

- bullet point contents
- bullet point contents
- bullet point contents

---

image

@yhatt
Copy link
Member

yhatt commented Feb 23, 2019

I've tested provided Markdown in VSCode 1.31.1 and ubuntu 18.10, but it did not reproduce.

screenshot from 2019-02-24 00-03-13

@yhatt
Copy link
Member

yhatt commented Feb 23, 2019

The other probable case to interfere is custom CSS style. Would you have any CSS file defined in markdown.styles preference?

In addition, it's worth a try to run VSCode with --diable-gpu option.

@tosaba
Copy link
Author

tosaba commented Feb 26, 2019

For me, it appears with default options and disabled extensions (v. 1.31.1 , ubuntu 18.04). I also didn't link any css stylesheets. I tested this on two separate computers with different graphics cards.

I also started vscode from the command line with --disable-gpu, but there is no difference.

@yhatt yhatt added the help wanted Extra attention is needed label Feb 27, 2019
@yhatt
Copy link
Member

yhatt commented Feb 27, 2019

I had tried to reproduce again in ubuntu 18.04.1 LTS, but it works correctly.

We added help wanted tag. PR is welcome if anyone resolves this.

@yhatt
Copy link
Member

yhatt commented Mar 20, 2019

My co-worker has reported a reproducible setting: "window.zoomLevel": 1.

zoom

@tosaba Could you confirm to show slide with correct scaling by resetting zoom level?

@tosaba
Copy link
Author

tosaba commented Mar 21, 2019

Thanks. I confirm that this causes the issue in my case

@yhatt yhatt closed this as completed in #19 Mar 22, 2019
@yhatt
Copy link
Member

yhatt commented Mar 22, 2019

Done. An updated v0.1.0 has a workaround for zoom level. Previewed slide would have correct scales.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants