Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent accidental conflict with globally polluted variables by VS Code #347

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Apr 22, 2022

See details at #345 (comment).

A minified preview script by Marp may override a global variable j provided by VS Code's Markdown preview. It is an important value for incremental update of Markdown contents so we have to prevent overloading in global context by wrapping the build output with IIFE.

Fix #345.

@yhatt yhatt merged commit 6ae1fe3 into main Apr 22, 2022
@yhatt yhatt deleted the iife-for-preview-script branch April 22, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown Preview update sometimes breaks down in the restored preview
1 participant