feat: implement reduceLazy (#239)
#245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phryxia
commented
Feb 17, 2024
Comment on lines
+57
to
+60
| reduce(f, iterable as any); | ||
| } | ||
| return (iterable: Iterable<unknown> | AsyncIterable<unknown>) => | ||
| reduce(f, seed, iterable as any); |
There was a problem hiding this comment.
I don't have any idea to overcome this, and reduce also uses as any so I just simply suppress them.
Actually it's common to use anyscript(😆) for implementation if type signatures are sufficiently provided.
| ) => IterableInfer<T> | Promise<IterableInfer<T>>, | ||
| ): (iterable: T) => ReturnValueType<T, IterableInfer<T>>; | ||
| f: AsyncReducer<IterableInfer<T>, IterableInfer<T>>, | ||
| ): (iterable: T) => ReturnValueType<T>; |
There was a problem hiding this comment.
ReturnValueType<T> is equivalent to ReturnValueType<T, IterableInfer<T>>. See ReturnValueType.ts.
|
Note that test succeed for |
ppeeou
reviewed
Feb 18, 2024
| * {@link https://github.com/marpple/FxTS/issues/239 | #related issue} | ||
| * | ||
| * For backward compatibility, `reduce` can support partial lazy form. | ||
| * You may want to use `reduceLazy` to use `seed`. |
There was a problem hiding this comment.
Suggested change
| * You may want to use `reduceLazy` to use `seed`. | |
| * You may want to use {@link https://fxts.dev/docs/reduceLazy | reduceLazy} to use `seed`. |
| expect(reduce([])).toEqual("seed"); | ||
| }); | ||
|
|
||
| it("should be occured error when the given `iterable` is an empty array and initial value is absent", () => { |
There was a problem hiding this comment.
Suggested change
| it("should be occured error when the given `iterable` is an empty array and initial value is absent", () => { | |
| it("should be occurred error when the given `iterable` is an empty array and initial value is absent", () => { |
|
LGTM👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239
reduceasSyncReducerandAsyncReducerreduceandreduceLazyreduceLazyreducecovers lazy cases 100%, but it wasn'treducewith rich dedicated typesreduceLazySyncReducervsAsyncReducerIterablevsAsyncIterablereducereduce