Page imagederivatives #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyrax::DerivativeService only runs the first derivative service class whose instance is valid for the given file set. We would rather have the ability to run multiple derivative pipelines. Keeping to the same method interface contract as Hyrax::DerivativeService, we could have one "plugin" be a composed runner of other derivative service plugins, running each in order, not just the first valid plugin.
sha1 validation now. Run `bundle update` to upgrade your solr_wrapper.
Includes moving command constants from module to class, and making some some statements more compact in method defintions.
JP2DerivativeService.
Do not use static counts in matcher for registered plugin count, and do not presume exact set of registered plugins.
Premise: no unnecessary upsampling, smaller file sizes.
ImageMagick `identify` on Ubuntu 14.04 does not indicated presense of any color space such as "sRGB" or "CMYK", so we have to detect color as absense of Gray or bilevel/one-bit to make `NewspaperPageDerviativeService.use_color?` method work and pass on Travis CI.
This was referenced Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is PR for derivatives. The testing should be relatively comprehensive for all the plugins (JP2, TIFF, PDF).
I may need to add some additional notes to README, so that would be something to discuss before merge.
Also: quick note, Hyrax does not easily support JP2 master/source files OOTB on Ubuntu, since it uses ImageMagick exclusively for hydra-derivatives, and ImageMagick on Ubuntu does not support JP2 decoding. JP2 file upload breaks thumbnail creation OOTB on Ubuntu. This may be a reason to (eventually, sooner or later) make our own thumbnail maker to replace what Hyrax does OOTB (one that falls back to graphicsmagick, so we can support JP2 masters without telling consumers of newspaper_works to build their own ImageMagick from source). I may add a ticket for this later this week, as a backlog item.