Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heirarchical traits, cleanup, fixes, and improvements. #41

Open
wants to merge 33 commits into
base: develop
Choose a base branch
from

Conversation

amcgregor
Copy link
Member

  • Heirarchical base trait.
  • HPath path-based heirarchical trait.
  • HParent adjacency list-based heirarchical trait.

Additional substantial changes:

  • Fix: Filter comparisons involving None values attempting to utilize typecasting.
  • Add: Date field timezone conversion and naïve date handling.

Additionally:

  • Minor optimizations for CPython.
  • More and better documentation.
  • Cleanup of dead imports, code, testing, deprecation warnings, and Python egg legacy.
  • Updated dependencies, and preferential use of pytz.utc over bson.tz_util.utc if available.
  • In the Queryable (beta) trait, await is becoming a reserved word in Python 3.7 so use wait instead.

@amcgregor amcgregor added 1.bug Defects requiring correction. 2.enhancement New ideas or improvements. area:field Issues relating to Field implementations or their mechanics. area:filtering Issues relating to parametric or direct query construction. area:trait Issues relating to specific existing or new traits. need:test For task completion, tests covering the development are required. labels May 31, 2017
@amcgregor amcgregor added this to the 1.1.2 Release milestone May 31, 2017
@amcgregor amcgregor self-assigned this May 31, 2017
@codecov
Copy link

codecov bot commented May 31, 2017

Codecov Report

Merging #41 into develop will decrease coverage by 10.27%.
The diff coverage is 33.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop      #41       +/-   ##
============================================
- Coverage      100%   89.72%   -10.28%     
============================================
  Files           51       52        +1     
  Lines         1835     2053      +218     
============================================
+ Hits          1835     1842        +7     
- Misses           0      211      +211
Impacted Files Coverage Δ
marrow/mongo/core/trait/heir/hparent.py 0% <0%> (ø)
marrow/mongo/core/trait/heir/hpath.py 0% <0%> (ø)
marrow/mongo/core/trait/heir/base.py 0% <0%> (ø)
marrow/mongo/core/trait/queryable.py 100% <100%> (ø) ⬆️
marrow/mongo/core/field/ttl.py 100% <100%> (ø) ⬆️
marrow/mongo/util/__init__.py 100% <100%> (ø) ⬆️
marrow/mongo/core/trait/identified.py 100% <100%> (ø) ⬆️
marrow/mongo/core/field/array.py 100% <100%> (ø) ⬆️
marrow/mongo/query/query.py 100% <100%> (ø) ⬆️
marrow/mongo/core/field/date.py 81.53% <79.66%> (-18.47%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 186ed2b...c9ff728. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.bug Defects requiring correction. 2.enhancement New ideas or improvements. area:field Issues relating to Field implementations or their mechanics. area:filtering Issues relating to parametric or direct query construction. area:trait Issues relating to specific existing or new traits. need:test For task completion, tests covering the development are required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant