Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign bands given devices of subtasks #2276

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Assign bands given devices of subtasks #2276

merged 2 commits into from
Aug 2, 2021

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Aug 1, 2021

What do these changes do?

Assign bands according to its device.

Related issue number

Fixes #2275

@wjsi wjsi added type: enhancement request to be backported Indicate that the PR need to be backported to stable branch mod: scheduling service labels Aug 1, 2021
@wjsi wjsi added this to the v0.8.0a1 milestone Aug 1, 2021
@wjsi wjsi changed the title Assign to bands given band prefixes Assign bands given devices of subtasks Aug 1, 2021
@wjsi wjsi marked this pull request as ready for review August 1, 2021 09:07
qinxuye
qinxuye approved these changes Aug 1, 2021
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hekaisheng
hekaisheng approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 92cd6c8 into mars-project:master Aug 2, 2021
@wjsi wjsi deleted the enh/gpu_assign branch August 2, 2021 02:32
@wjsi wjsi mentioned this pull request Aug 2, 2021
Merged
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Aug 2, 2021
chaokunyang pushed a commit to chaokunyang/mars that referenced this pull request Aug 16, 2021
@wjsi @chaokunyang
Assign bands given devices of subtasks (mars-project#2276)
2c77203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@hekaisheng hekaisheng hekaisheng approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: scheduling service type: enhancement request
Projects
None yet
Milestone
v0.8.0a1
Development

Successfully merging this pull request may close these issues.

Assign bands given devices of subtasks
3 participants
@wjsi @qinxuye @hekaisheng