Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs of DataFrame.assign #2367

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Aug 22, 2021

What do these changes do?

Fix documentation of assign as they cannot work as expected. Also reduce unneeded tests.

Related issue number

@wjsi wjsi added type: enhancement request type: docs to be backported Indicate that the PR need to be backported to stable branch labels Aug 22, 2021
@wjsi wjsi added this to the v0.8.0a2 milestone Aug 22, 2021
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 4d92bc4 into mars-project:master Aug 23, 2021
wjsi added a commit to wjsi/mars that referenced this pull request Aug 23, 2021
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Aug 23, 2021
@wjsi wjsi deleted the doc/assign branch August 23, 2021 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants