Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API for subtask DAG structure #2389

Merged
merged 70 commits into from
Aug 31, 2021
Merged

API for subtask DAG structure #2389

merged 70 commits into from
Aug 31, 2021

Conversation

RandomY-2
Copy link
Contributor

What do these changes do?

API endpoint to collect subtask DAG structure

Related issue number

The API part of #2384

RandomY-2 and others added 23 commits August 20, 2021 14:51
@qinxuye qinxuye added this to the v0.8.0a3 milestone Aug 31, 2021
@wjsi wjsi added the to be backported Indicate that the PR need to be backported to stable branch label Aug 31, 2021
wjsi
wjsi reviewed Aug 31, 2021
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, I left some comments.

mars/services/task/supervisor/processor.py Outdated Show resolved Hide resolved
mars/services/task/supervisor/processor.py Show resolved Hide resolved
mars/services/task/supervisor/processor.py Outdated Show resolved Hide resolved
mars/services/task/supervisor/processor.py Outdated Show resolved Hide resolved
wjsi
wjsi approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qinxuye
qinxuye approved these changes Aug 31, 2021
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 4a53c48 into mars-project:master Aug 31, 2021
wjsi pushed a commit to wjsi/mars that referenced this pull request Aug 31, 2021
@RandomY-2 @wjsi
API for subtask DAG structure (mars-project#2389)
f979aab
@wjsi wjsi mentioned this pull request Aug 31, 2021
Merged
hekaisheng pushed a commit that referenced this pull request Sep 1, 2021
@wjsi @RandomY-2
API for subtask DAG structure (#2389) (#2410)
66d7bef 
Co-authored-by: RandomY-2 <69881587+RandomY-2@users.noreply.github.com>
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@wjsi wjsi wjsi approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: task service mod: web type: feature New feature
Projects
None yet
Milestone
v0.8.0a3
Development

Successfully merging this pull request may close these issues.
3 participants
@RandomY-2 @qinxuye @wjsi