Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NotImplementedError for mo.batch when single call not implemented #2635

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Jan 17, 2022

What do these changes do?

Fix error for mo.batch when single call not implemented. Also remove forked pytest-asyncio as bug already been fixed.

Related issue number

Fixes #2634

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added type: bug Something isn't working mod: actor to be backported Indicate that the PR need to be backported to stable branch labels Jan 17, 2022
@wjsi wjsi added this to the v0.9.0a2 milestone Jan 17, 2022
@wjsi wjsi requested a review from qinxuye as a code owner January 17, 2022 08:57
@wjsi wjsi changed the title Fix error for mo.batch when single call not implemented Fix NotImplementedError for mo.batch when single call not implemented Jan 17, 2022
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 1f6c3d4 into mars-project:master Jan 18, 2022
wjsi added a commit to wjsi/mars that referenced this pull request Jan 18, 2022
qinxuye pushed a commit that referenced this pull request Jan 18, 2022
qinxuye pushed a commit to hekaisheng/mars that referenced this pull request Jan 21, 2022
@wjsi wjsi deleted the bugfix/single_not_implemented branch January 21, 2022 08:04
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported already PR has been backported mod: actor type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] NotImplementedError raised when calling with batch
3 participants