Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HTTP request rewriter #2664

Merged
merged 2 commits into from
Jan 30, 2022
Merged

Add support for HTTP request rewriter #2664

merged 2 commits into from
Jan 30, 2022

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Jan 29, 2022

What do these changes do?

Add an argument for HTTP request rewriter which accepts an argument representing the request object.

Related issue number

Fixes #2663

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added type: enhancement request mod: web to be backported Indicate that the PR need to be backported to stable branch labels Jan 29, 2022
@wjsi wjsi added this to the v0.9.0a2 milestone Jan 29, 2022
@wjsi wjsi added this to In progress in Distributed via automation Jan 29, 2022
hekaisheng
hekaisheng approved these changes Jan 30, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qinxuye
qinxuye approved these changes Jan 30, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 208e68a into mars-project:master Jan 30, 2022
Distributed automation moved this from In progress to Done Jan 30, 2022
wjsi added a commit to wjsi/mars that referenced this pull request Jan 30, 2022
@wjsi
Add support for HTTP request rewriter (mars-project#2664)
c3af916
@wjsi wjsi mentioned this pull request Jan 30, 2022
Merged
@wjsi wjsi deleted the enh/req_wrapper branch January 30, 2022 07:02
qinxuye pushed a commit that referenced this pull request Jan 30, 2022
@wjsi
[BACKPORT] Add support for HTTP request rewriter (#2664) (#2665)
b47e27d
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@hekaisheng hekaisheng hekaisheng approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: web type: enhancement request
Projects
Distributed
  
Done
Milestone
v0.9.0a2
Development

Successfully merging this pull request may close these issues.

Add support for HTTP request rewriter
3 participants
@wjsi @qinxuye @hekaisheng