Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NameError: name 'pq' is not defined if pyarrow is not installed #2751

Merged
merged 1 commit into from Feb 25, 2022
Merged

Fix NameError: name 'pq' is not defined if pyarrow is not installed #2751

merged 1 commit into from Feb 25, 2022

Conversation

fyrestone
Copy link
Contributor

What do these changes do?

Fix NameError: name 'pq' is not defined if pyarrow is not installed

Related issue number

Fixes #2746

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@fyrestone fyrestone self-assigned this Feb 25, 2022
wjsi
wjsi approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qinxuye
qinxuye approved these changes Feb 25, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 64520f3 into mars-project:master Feb 25, 2022
@qinxuye qinxuye added to be backported Indicate that the PR need to be backported to stable branch type: bug Something isn't working labels Feb 25, 2022
@qinxuye qinxuye added this to In progress in Misc via automation Feb 25, 2022
@qinxuye qinxuye added this to PR-In progress in v0.9 Release via automation Feb 25, 2022
@qinxuye qinxuye added this to the v0.9.0b2 milestone Feb 25, 2022
@qinxuye qinxuye mentioned this pull request Feb 25, 2022
Merged
@qinxuye qinxuye added backported already PR has been backported mod: dataframe and removed to be backported Indicate that the PR need to be backported to stable branch labels Mar 1, 2022
qinxuye pushed a commit to hekaisheng/mars that referenced this pull request Mar 1, 2022
@fyrestone
Fix NameError: name 'pq' is not defined if pyarrow is not installed (m…
63e537e 
…ars-project#2751)
@qinxuye qinxuye removed this from PR-In progress in v0.9 Release May 7, 2022
@qinxuye qinxuye added this to PR-In progress in v0.10 Release via automation May 7, 2022
@qinxuye qinxuye removed this from PR-In progress in v0.10 Release May 7, 2022
@qinxuye qinxuye added this to PR-In progress in v0.9 Release via automation May 7, 2022
@qinxuye qinxuye moved this from PR-In progress to PR-Done in v0.9 Release May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@wjsi wjsi wjsi approved these changes

@hekaisheng hekaisheng Awaiting requested review from hekaisheng

Assignees

@fyrestone fyrestone

Labels
backported already PR has been backported mod: dataframe type: bug Something isn't working
Projects
Misc
  
In progress
v0.9 Release
PR-Done
Milestone
v0.9.0b2
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot import mars when pyarrow not installed
3 participants
@fyrestone @qinxuye @wjsi