Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix read_ray_dataset is not compatible with the latest Ray #3318

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Fix read_ray_dataset is not compatible with the latest Ray #3318

merged 2 commits into from
Jan 12, 2023

Conversation

fyrestone
Copy link
Contributor

@fyrestone fyrestone commented Jan 12, 2023 •
edited

What do these changes do?

Fix read_ray_dataset is not compatible with the latest Ray

Related issue number

Fixes #3317

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@fyrestone fyrestone added the type: bug Something isn't working label Jan 12, 2023
@fyrestone fyrestone self-assigned this Jan 12, 2023
@fyrestone fyrestone changed the title Fix read_ray_dataset is not compatible with latest Ray Fix read_ray_dataset is not compatible with the latest Ray Jan 12, 2023
@fyrestone fyrestone marked this pull request as ready for review January 12, 2023 06:09
@fyrestone fyrestone requested a review from a team as a code owner January 12, 2023 06:09
@vcfgv vcfgv mentioned this pull request Jan 12, 2023
Merged
2 tasks
zhongchun
zhongchun approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@zhongchun zhongchun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

chaokunyang
chaokunyang approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaokunyang chaokunyang merged commit 7181876 into mars-project:master Jan 12, 2023
qianduoduo0904 pushed a commit to qianduoduo0904/mars that referenced this pull request Jan 16, 2023
@fyrestone @qianduoduo0904
Fix read_ray_dataset is not compatible with the latest Ray (mars-proj…
345c38c 
…ect#3318)

* Fix read_ray_dataset

* Fix

Co-authored-by: 刘宝 <po.lb@antgroup.com>
(cherry picked from commit 7181876)
ChengjieLi28 pushed a commit to xorbitsai/mars that referenced this pull request Jan 17, 2023
@fyrestone @ChengjieLi28
Fix read_ray_dataset is not compatible with the latest Ray (mars-proj…
549dd20 
…ect#3318)

* Fix read_ray_dataset

* Fix

Co-authored-by: 刘宝 <po.lb@antgroup.com>
(cherry picked from commit 7181876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongchun zhongchun zhongchun approved these changes

@chaokunyang chaokunyang chaokunyang approved these changes

Assignees

@fyrestone fyrestone

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] md.read_ray_dataset is not compatible with latest Ray
3 participants
@fyrestone @zhongchun @chaokunyang