Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin version of xgboost_ray and use latest ray when CI #3319

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Unpin version of xgboost_ray and use latest ray when CI #3319

merged 1 commit into from
Jan 13, 2023

Conversation

vcfgv
Copy link
Contributor

@vcfgv vcfgv commented Jan 12, 2023 •
edited
Loading

What do these changes do?

  • Unpin xgboost_ray version when CI
  • Use latest ray when CI

Related issue number

#3318 Fix read_ray_dataset is not compatible with the latest Ray

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@vcfgv vcfgv requested a review from a team as a code owner January 12, 2023 05:57
@vcfgv vcfgv force-pushed the update_xgboost_version_for_ci branch 2 times, most recently from 1806d75 to 881f968 Compare January 12, 2023 08:35
@vcfgv vcfgv changed the title WIP: Unpin version of xgboost_ray when CI Unpin version of xgboost_ray and use latest ray when CI Jan 12, 2023
@vcfgv vcfgv force-pushed the update_xgboost_version_for_ci branch from 881f968 to 3e2af90 Compare January 13, 2023 04:52
@vcfgv
Skip tests for MLDataset when ray>=2.0
7f91017 
Use latest ray

Temporarily pin numpy
@vcfgv vcfgv force-pushed the update_xgboost_version_for_ci branch from 3e2af90 to 7f91017 Compare January 13, 2023 05:03
fyrestone
fyrestone approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@fyrestone fyrestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhongchun
zhongchun approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@zhongchun zhongchun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fyrestone fyrestone merged commit 194021c into mars-project:master Jan 13, 2023
qianduoduo0904 pushed a commit to qianduoduo0904/mars that referenced this pull request Jan 16, 2023
@vcfgv @qianduoduo0904
Skip tests for MLDataset when ray>=2.0 (mars-project#3319)
f3911cd 
Use latest ray

Temporarily pin numpy

(cherry picked from commit 194021c)
ChengjieLi28 pushed a commit to xorbitsai/mars that referenced this pull request Jan 17, 2023
@vcfgv @ChengjieLi28
Skip tests for MLDataset when ray>=2.0 (mars-project#3319)
93e5b3e 
Use latest ray

Temporarily pin numpy

(cherry picked from commit 194021c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongchun zhongchun zhongchun approved these changes

@fyrestone fyrestone fyrestone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vcfgv @zhongchun @fyrestone