Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ObjectData and ObjectChunk to represent data beyond ndarray, dataframe etc #805

Merged
merged 3 commits into from
Nov 9, 2019
Merged

Add ObjectData and ObjectChunk to represent data beyond ndarray, dataframe etc #805

merged 3 commits into from
Nov 9, 2019

Conversation

qinxuye
Copy link
Collaborator

@qinxuye qinxuye commented Nov 5, 2019 •
edited
Loading

What do these changes do?

This PR added ObjectData and ObjectChunk to represent data beyond ndarray, dataframe, series etc. Learn operand has been added as well, and xgboost operands have been refactored also.

Related issue number

NA

@qinxuye qinxuye added this to the v0.3.0b2 milestone Nov 5, 2019
@qinxuye qinxuye added type: feature New feature and removed type: enhancement request labels Nov 5, 2019
hekaisheng
hekaisheng previously approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one little typo and I think output_type is indeed a better name than object_type for many DataFrame operands like reductions as its output can be DataFrame or Series, I will rename it in next PR.

mars/learn/contrib/xgboost/start_tracker.py Outdated Show resolved Hide resolved
@qinxuye
Copy link
Collaborator Author

qinxuye commented Nov 7, 2019

LGTM except one little typo and I think output_type is indeed a better name than object_type for many DataFrame operands like reductions as its output can be DataFrame or Series, I will rename it in next PR.

Agreed.

@qinxuye qinxuye mentioned this pull request Nov 7, 2019
Merged
2 tasks
hekaisheng
hekaisheng approved these changes Nov 9, 2019
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 0137637 into mars-project:master Nov 9, 2019
@qinxuye qinxuye deleted the enh/object-tileable-chunk branch November 16, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hekaisheng hekaisheng hekaisheng approved these changes

Assignees
No one assigned
Labels
mod: learn type: feature New feature
Projects
None yet
Milestone
v0.3.0b2
Development

Successfully merging this pull request may close these issues.
2 participants
@qinxuye @hekaisheng