Add missing parameter #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -371,7 +374,7 @@ class Field(FieldABC): | |||
|
|
|||
| def __init__(self, default=None, attribute=None, load_from=None, error=None, | |||
| validate=None, required=False, allow_none=False, load_only=False, | |||
| dump_only=False, **metadata): | |||
| dump_only=False, missing=None, **metadata): | |||
There was a problem hiding this comment.
None should be a valid value for missing. Perhaps you can make the default null here to allow None to be used as a value for missing data.
P.S. Have you an idea on when you'll have the time to release 2.0? |
|
Thanks @philtay. I don't have a scheduled release date for 2.0, but I'm hoping to have 2.0-a released within the next 2-3 weeks. |
|
@sloria don't forget to update the changelog with this new parameter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #115
If it's ok tests and docs will be added.