Fix integration for HA versions 2021.12.0 or later #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in marthoc#38, this simple fix should address this problem - and it did for me as well. I assume this will not cause problems for folks who use the integration with earlier versions, but it'd be great if someone could check my assumption there!
|
Hello,
Any chance of getting the light as a light instead of a switch? I’d like to control the brightness form HA.
Derek
… On Dec 18, 2021, at 6:08 PM, Kevin David ***@***.***> wrote:
As reported in #38 <#38>, this simple fix should address this problem - and it did for me as well.
I assume this will not cause problems for folks who use the integration with earlier versions, but it'd be great if someone could check my assumption there!
You can view, comment on, or merge this pull request online at:
#41 <#41>
Commit Summary
e907377 <e907377> Fix integration for HA versions 2021.12.0 or later
File Changes (1 file <https://github.com/marthoc/kuna/pull/41/files>)
M custom_components/kuna/camera.py <https://github.com/marthoc/kuna/pull/41/files#diff-0ed86c5a2cda30bee4bfb215d1bc3bf13c3766ae07358cf1da75250533a3b47f> (2)
Patch Links:
https://github.com/marthoc/kuna/pull/41.patch <https://github.com/marthoc/kuna/pull/41.patch>
https://github.com/marthoc/kuna/pull/41.diff <https://github.com/marthoc/kuna/pull/41.diff>
—
Reply to this email directly, view it on GitHub <#41>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHOJDTKRVCWQW3S6AHV7HT3URUWCNANCNFSM5KLI4R3Q>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.
|
|
I tried this fix, changing Line 100: self.is_streaming = True to self._is_streaming = True, but still not video feed. Any other ideas? Really missing this camera feed on my HA. |
|
@eastonking I don't think the video feed was ever implemented, all that works is pulling snapshots every once in a while right now. |
|
100% was working in the past. And apparently others have "fixed" it by
changing this live value.
…On Sun, Apr 10, 2022, 1:25 PM Kevin David ***@***.***> wrote:
@eastonking <https://github.com/eastonking> I don't think the video feed
was ever implemented, all that works is pulling snapshots every once in a
while right now.
—
Reply to this email directly, view it on GitHub
<#41 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADHWNAXRHTE4PLFQLTY67X3VEMFG7ANCNFSM5KLI4R3Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@eastonking if by "streaming" you mean "update an image every N seconds via http" then yes, I think this is working for people. But true video streaming (like RSTP), I don't think anyone's done that yet. I spent some time investigating that for fun and posted my initial results here: #44 |
|
well, yes, that is what I meant, I realize it wasn't a full video stream,
but I can't get anything to work at all, not even the snapshot every N
seconds :(
…On Mon, Apr 11, 2022 at 10:23 AM Kevin David ***@***.***> wrote:
@eastonking <https://github.com/eastonking> if by "streaming" you mean
"update an image every N seconds via http" then yes, I think this is
working for people.
But true video streaming (like RSTP), I don't think anyone's done that
yet. I spent some time investigating that for fun and posted my initial
results here: #44 <#44>
—
Reply to this email directly, view it on GitHub
<#41 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADHWNAVX3S6Q7IAYWHKGTN3VEQYXTANCNFSM5KLI4R3Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Ah I see. Well it seems to be working for me on the latest HA with my fork. https://github.com/kevin-david/kuna - feel free to give that a shot after uninstalling this version via HACS |
|
kevin-david, while working it, please change the switch to a light. Any chance to include the speaker? |
|
The new version of Home Assistant has "switch as X" support in the UI so no
source code changes are necessary to do that actually:
https://www.home-assistant.io/integrations/switch_as_x/
I suspect using the speaker will be equally as hard as getting the RTSP
stream from the websocket (I also suspect they use the same transport
stream, just a different message type or "channel"), so it won't be easy
and I can't predict if or when I'll be able to look into it again.
…On Mon, Apr 11, 2022, 2:08 PM mcfarlde ***@***.***> wrote:
kevin-david,
while working it, please change the switch to a light. Any chance to
include the speaker?
—
Reply to this email directly, view it on GitHub
<#41 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOVQ4RTVK2ATI2WVGH7TXTVERTAVANCNFSM5KLI4R3Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #38, this simple fix should address this problem - and it did for me as well.
I assume this will not cause problems for folks who use the integration with earlier versions, but it'd be great if someone could check my assumption there!
Closes #38