Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2021.12.0 Breaks Kuna Camera Streaming #38

Open
Gpssysop opened this issue Dec 13, 2021 · 9 comments · May be fixed by #41
Open

v2021.12.0 Breaks Kuna Camera Streaming #38

Gpssysop opened this issue Dec 13, 2021 · 9 comments · May be fixed by #41

Comments

@Gpssysop
Copy link

After upgrading to core-2021.12.0, my Kuna cameras would no longer stream. I tried deleting and re-adding the integration, but I'm still getting the same error in the logs:

Logger: homeassistant.components.camera
Source: custom_components/kuna/camera.py:100
Integration: Camera (documentation, issues)
First occurred: 9:50:49 PM (2 occurrences)
Last logged: 9:50:49 PM

kuna: Error on device update!
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 431, in _async_add_entity
await entity.async_device_update(warning=False)
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 684, in async_device_update
await task
File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/kuna/camera.py", line 100, in update
self.is_streaming = True
AttributeError: can't set attribute

@DVarao
Copy link

DVarao commented Dec 13, 2021

Ha. Thought it was just me. Looking forward to a fix, let me know if I can provide any logs etc.

@mcfarlde
Copy link

mcfarlde commented Dec 13, 2021 via email

@Gpssysop
Copy link
Author

@mcfarlde Good call. That worked for me as well.

kevin-david added a commit to kevin-david/kuna that referenced this issue Dec 19, 2021
As reported in marthoc#38, this simple fix should address this problem - and it did for me as well. 

I assume this will not cause problems for folks who use the integration with earlier versions, but it'd be great if someone could check my assumption there!
@kevin-david kevin-david linked a pull request Dec 19, 2021 that will close this issue
@kevin-david
Copy link

Thanks @mcfarlde for the suggestion - it worked for me as well. I created this trivial PR to keep things up to date: #41

@chheiss
Copy link

chheiss commented Jan 18, 2022

I don't get any camera entities (only switches and motion) when installing the addon. Any ideas? HA 2021.12.10

kevin-david pushed a commit to kevin-david/kuna that referenced this issue Apr 10, 2022
As reported in marthoc#38, this simple fix should address this problem - and it did for me as well. 

I assume this will not cause problems for folks who use the integration with earlier versions, but it'd be great if someone could check my assumption there!
@smarterplace
Copy link

after making the change, I am seeing this error. Any ideas?

File "/usr/src/homeassistant/homeassistant/components/camera/__init__.py", line 179, in _async_get_image if image_bytes := await camera.async_camera_image( TypeError: async_camera_image() got an unexpected keyword argument 'width'

@ffpllc
Copy link

ffpllc commented Dec 4, 2022

I'm getting the same:

File "/usr/src/homeassistant/homeassistant/components/camera/init.py", line 169, in _async_get_image
if image_bytes := await camera.async_camera_image(
TypeError: KunaCamera.async_camera_image() got an unexpected keyword argument 'width'

@mcfarlde
Copy link

mcfarlde commented Dec 5, 2022

I updated HACS, rebooted and now the camera is back!

@mcfarlde
Copy link

mcfarlde commented Dec 7, 2022

I only get that error when using Safari. The camera works in chrome, the Mac App and the mobile app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants