Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General code improvements #36

Merged
merged 2 commits into from
Sep 1, 2020
Merged

General code improvements #36

merged 2 commits into from
Sep 1, 2020

Conversation

martimunicoy
Copy link
Owner

@martimunicoy martimunicoy commented Sep 1, 2020 •
edited
Loading

Description

Some general improvements can be added to the code.

@martimunicoy martimunicoy added the enhancement New feature or request label Sep 1, 2020
@martimunicoy martimunicoy added this to In progress in 0.3.0 via automation Sep 1, 2020
@martimunicoy martimunicoy merged commit 3c7cfc9 into devel Sep 1, 2020
0.3.0 automation moved this from In progress to Done Sep 1, 2020
@lgtm-com
Copy link

lgtm-com bot commented Sep 1, 2020

This pull request fixes 9 alerts when merging 5cce518 into 52ae845 - view on LGTM.com

fixed alerts:

  • 6 for First parameter of a method is not named 'self'
  • 1 for Module is imported more than once
  • 1 for Unused import
  • 1 for 'import *' may pollute namespace

@martimunicoy martimunicoy deleted the code_enhancement branch September 1, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
0.3.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@martimunicoy