Bug: stored JSON value may be integer/float/string

[strider2038]

We are storing variable type of data in JSONB field. It can be object, integer, float or string. So we have an issue with Jsonb and primitive types. I think array type must be removed from these methods.

https://github.com/martin-georgiev/postgresql-for-doctrine/blob/master/src/MartinGeorgiev/Doctrine/DBAL/Types/Jsonb.php#L45
https://github.com/martin-georgiev/postgresql-for-doctrine/blob/master/src/MartinGeorgiev/Doctrine/DBAL/Types/JsonTransformer.php#L33

[martin-georgiev]

Can you share an example with the actual outcome and the expected one?

[strider2038]

JSON is not always objects or arrays. String or numeric values are valid JSON too. So this code

json_decode("\"string\"", true);

returns string result and leads to type exception here https://github.com/martin-georgiev/postgresql-for-doctrine/blob/master/src/MartinGeorgiev/Doctrine/DBAL/Types/JsonTransformer.php#L33.

[martin-georgiev]

@strider2038 do you mind confirming the changes in #66 will fix the use-case you have?

[strider2038]

@strider2038 do you mind confirming the changes in #66 will fix the use-case you have?

Yes, this solves our issue. Thanks.

[martin-georgiev]

Cool, it is released in the last version published for Composer.