Allow the primitive types of integer, string and float to be stored in a Jsonb field #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 294
💛 - Coveralls |
martin-georgiev
commented
Apr 18, 2020
| @@ -37,7 +37,7 @@ return PhpCsFixer\Config::create() | |||
| 'php_unit_method_casing' => ['case' => 'snake_case'], | |||
| 'php_unit_test_class_requires_covers' => false, | |||
| 'phpdoc_types_order' => ['null_adjustment' => 'always_last'], | |||
| 'simplified_null_return' => true, | |||
There was a problem hiding this comment.
This had to change because PHP-CS-Fixer/PHP-CS-Fixer#2349 suddenly started showing its teeth here.
🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the
jsonblimitation described in #58. Until now the only way to work-around it was to wrap the desired primitive value in an array, which honestly was a hack.The changes are not perceived as backwards incompatible as full compatibility for older values is maintained.