Migrate to ASP.NET Core 2.1 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
=========================================
+ Coverage 57.47% 58.9% +1.42%
=========================================
Files 66 68 +2
Lines 3149 3105 -44
Branches 413 403 -10
=========================================
+ Hits 1810 1829 +19
+ Misses 1153 1088 -65
- Partials 186 188 +2
Continue to review full report at Codecov.
|
Update to use ASP.NET Core 2.1 (preview 1) and HttpClientFactory.
Use Microsoft.AspNetCore.Mvc.Testing for integration tests.
Remove Microsoft.VisualStudio.Web.CodeGeneration.Tools as it appears to be failing to restore NuGet packages.
Update the version of the site to 2.1.0.
Use explicit versions of gulp and npm in CI. Update to npm 5.7.1.
Add middlewares for HSTS and HTTP to HTTPS redirection.
Configure HSTS and remove header from custom middleware.
Fix integration tests by setting the test server base address to HTTPS.
Use in-process IIS hosting instead of the reverse-proxy hosting.
Update all npm packages to their latest versions.
Downgrade karma-typescript to a version that works.
martincostello
force-pushed
the
AspNetCore-2.1
branch
from
d86be77
to
9c75fdd
Compare
Fix code analysis warnings for string comparisons. Work around incorrect "assembly version missing" warnings.
Run gulp publish when the site project is opened.
Use Microsoft.AspNetCore.App instead of Microsoft.AspNetCore.All.
Update to preview 2 of .NET Core 2.1. Update various other dependencies to their latest versions.
|
The logging is a lot more verbose when running in CI now - need to turn it down to speed up the build. Might be to do with the changes to the fixture for the integration tests. |
Update to release candidate 1 of .NET Core 2.1. Update various other dependencies to their latest versions.
Use the early access NuGet feed to migrate to the RTM version of ASP.NET Core 2.1.
Update npm packages and lock file after merge.
Update to npm 6.1.0.
|
Once RTM packages are in nuget.org, just need to drop the extra NuGet feed and then will do a squash merge. |
Refactor application startup to remove redundant setup of configuration, move configuration into the host building, remove the need to use TestStartup and prepare to remove StartupBase.
Reduce the log verbosity used when running on the console for local development.
Remove the separate StartupBase class and just use a single Startup class.
Remove redundant configuration for the application builder.
Remove the need to explicitly set the tests to run as Development instead of Production.
|
Comparing fe55939 against a6f946a using Kestrel in Development mode: BenchmarkDotNet=v0.10.14, OS=Windows 10.0.17134
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=2.1.300
[Host] : .NET Core 2.1.0 (CoreCLR 4.6.26515.07, CoreFX 4.6.26515.06), 64bit RyuJIT
DefaultJob : .NET Core 2.1.0 (CoreCLR 4.6.26515.07, CoreFX 4.6.26515.06), 64bit RyuJIT
|
|
Looks like there’s some double-logging going on. |
Fix logs being written to Serilog twice.
Update the log levels used in the tests to reduce CI verbosity (hopefully).
Remove configuration for IIS in-process hosting as this is no longer part of ASP.NET Core 2.1.0.
Remove the early-access download feed URL for 2.1.0 now that the packages have been published to nuget.org.
Revert to using tags to get the script to download the SDK.
|
Just waiting for Azure Web Apps to deploy the |
Revert to karma 1.3.0 (for now) as it does not work in VSTS.
martincostello
changed the title
Migrate to puppeteer from PhantomJS as it doesn't work in VSTS anymore.
Downgrade console.error() to console.warn() when trying to register a service worker.
martincostello
added a commit
that referenced
this pull request
Jun 2, 2018
Fix the launch configuration for VS Code broken by #178.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the application to ASP.NET Core 2.1. Changes include:
2.1.300.2.1.0.Microsoft.AspNetCore.AppNuGet package instead ofMicrosoft.AspNetCore.All.Microsoft.Extensions.Http(HttpClientFactory) for use ofHttpClient.Microsoft.AspNetCore.Mvc.Testingfor integration tests.Refitto call the TfL API.