Add Dockerfile for arm64 compilation #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
added
enhancement
github_actions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
=======================================
Coverage 96.72% 96.72%
=======================================
Files 45 45
Lines 641 641
Branches 71 71
=======================================
Hits 620 620
Misses 7 7
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/deploy dev |
Add a Dockerfile to compile for arm64 AoT on GitHub Actions (until they have a native arm64 runner).
martincostello
force-pushed
the
arm64
branch
from
7bf8712
to
29c9fc7
Compare
|
/deploy dev |
|
AoT on x86_64: Published size: 39.1MB; 4 files AoT on arm64: Published size: 39.2MB; 4 files TL;DR: Published size: +4% |
Ensure that the .NET SDK in global.json is installed on the Docker image to account for lag between new release and Docker image publishing.
martincostello
added a commit
that referenced
this pull request
Nov 28, 2023
Cross-architecture compile for arm64 on GitHub Actions' ubuntu-latest hosted runner. See https://learn.microsoft.com/dotnet/core/deploying/native-aot/cross-compile#linux. Effectively a revert of #973.
martincostello
added a commit
that referenced
this pull request
Nov 28, 2023
Cross-architecture compile for arm64 on GitHub Actions' ubuntu-latest hosted runner without using Docker. See https://learn.microsoft.com/dotnet/core/deploying/native-aot/cross-compile#linux. Effectively a revert of #973. Also explicitly specify using bash as the shell where appropriate.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Dockerfile to compile for arm64 AoT on GitHub Actions (until they have a native arm64 runner).