-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observe implementation #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very nice! |
I think it can be merged now, I've tested today that the basic flow works with an actual connection. I may open more PRs if I'll notice issues when I'll have more time in future to use it more exhaustively |
The line width limit makes it uglier sometimes, but at least it's consistent.
Thank you, I appreciate that you took the time to explain the differences of your implementation and to document the exported types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of the Observe RFC 7252 based on the one in coap-rs/observe.rs with some noticeable differences.
BTreeMap<ResourcePath, Resource<Endpoint>>
smoltcp
here. The implementation could actually be moved here in future if someone else needs it.@martindisch give me some more time to test the implementation but the initial tests are promising 😄