Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hazelcast Jet - minor improvements #3

Merged
merged 1 commit into from Dec 14, 2019

Conversation

@jerrinot
Copy link
Contributor

jerrinot commented Dec 13, 2019

Hello Martin,

thank you for playing with Jet. I am sending minor improvements:

  1. Use local/test source as input
  2. Count the polluted regions inside Jet

Reasoning:
Jet can use various sources: TestSources is good for exploring/learning. You can use
IMDG IList too, but I don't see a good reason in this case.

There are sources for e.g. Apache Kafka, JMS, JDBC, HDFS, Redis and many other systems.
The same goes for Sinks: You can use IMDG, but also other systems.

In Jet 4.0 is going to be a support for a local collector - that will eliminate the IList even on the Sink side.

Once more thank you for trying Jet and if you have any question, my DM are open

2. Count the polluted regions inside Jet

Jet can use various sources: TestSources is good for exploring/learning. You can use
IMDG, but there are sources for e.g. Apache Kafka, HDFS, Redis and many other systems.

The same goes for Sinks: You can use IMDG, but also other systems.
@martinfmi

This comment has been minimized.

Copy link
Owner

martinfmi commented Dec 14, 2019

Thanks for the good feedback, Jaromir. I am merging the suggested changes.

@martinfmi martinfmi merged commit 5fbd05e into martinfmi:master Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.