Hazelcast Jet - minor improvements #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Count the polluted regions inside Jet Jet can use various sources: TestSources is good for exploring/learning. You can use IMDG, but there are sources for e.g. Apache Kafka, HDFS, Redis and many other systems. The same goes for Sinks: You can use IMDG, but also other systems.
|
Thanks for the good feedback, Jaromir. I am merging the suggested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Martin,
thank you for playing with Jet. I am sending minor improvements:
Reasoning:
Jet can use various sources: TestSources is good for exploring/learning. You can use
IMDG IList too, but I don't see a good reason in this case.
There are sources for e.g. Apache Kafka, JMS, JDBC, HDFS, Redis and many other systems.
The same goes for Sinks: You can use IMDG, but also other systems.
In Jet 4.0 is going to be a support for a local collector - that will eliminate the IList even on the Sink side.
Once more thank you for trying Jet and if you have any question, my DM are open