-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memo field is empty #10
Comments
Which bank are you using? https://docs.google.com/spreadsheets/d/11tAD5cfrlaOZ4HXI6jPpL5hMf8ZuRYc6TUXTxZE84A8/edit |
Hi, thank for the reply. |
Looks like your bank uses the Can you test with this image: |
Maybe it's related, I'm not really sure. But it looks like we need some kind of mapping between fields from Nordigen and YNAB. Because the fields you're looking for is completely different from what I get from my bank. It should be doable. |
@zdaar so, just to be sure, do you want this mapping between Nordigen and YNAB:
Is that right? |
This seems like partially the same things I am seeing i.e. payee should come from creditorName(or debitorName if the amount is positive). I already have a patched version which does this. But there is still debate going on how to actually have this on the main image so that it stays compatible enough. |
Hi Martin, I’ll come back to you soon on this iam pretty busy atm. I’m also
willing to contribute code if you take PR. Thanks for your help let’s talk
soon !
…On Sat, 15 Oct 2022 at 20:40, hpernu ***@***.***> wrote:
This seems like partially the same things I am seeing i.e. payee should
come from creditorName(or debitorName if the amount is positive).
I already have a patched version which does this. But there is still
debate going on how to actually have this on the main image so that it
stays compatible enough.
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAF4ERFO4ALKIC5ISAVTR3WDL3BXANCNFSM6AAAAAAQ4VDEL4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
It is now possible to have payee information to come from creditorName/debtorName by setting NORDIGEN_PAYEE_SOURCE=name . Does this resolve some of your issues? Although I see also the problem with memo field, does this payee setting make it more trackable in YNAB? Memo field being a (completely) freeform text that YNAB does not use for anything it would be particularly tricky to get right for everyone - some may want more data, others less, and some completely write their own. Some may even want an original payment amount there if the payment is made in foreign currency converted by bank. If there was any improvement, perhaps it could be a list of possible fields concatenated together - although there are space limits on memo field as well. Whether the work to do so is sensible, compared to manual editing, I do not know. |
Can the original creator of this issue respond whether current versions bring any help here? In particular:
Memo fields may still be unrelated to what you need but less likely to be empty. Payee name should allow you to more easily correct these manually. If there is no reply within a sensible time, should this be closed? |
Hi, I should be able to test everything by Sunday. Thanks for your work ! |
Is that the full JSON for a single transaction? i.e. There is no debtorName or creditorName ? I though they were mandatory. Unfortunately, it looks like what Martin suggested at some point i.e. building bank specific blocks to the actual source code. This will get complicated and seems like a maintenance nightmare but possibly is the only way to handle all possible banks. As long as we get to import enough data that transactions are distinguishable, the automation for all possible cases might not be worth it. Is it enough for you to set the payees manually if the additional information ends up in memo field? |
Yes, that is the full JSON for the first transaction. No debtorName or creditorName on any of the transactions in the response.
Would it be possible to add an option such as NORDIGEN_PAYEE_SOURCE=custom along with another environmental variable with the field name for that bank? As we need a separate env-file for each account anyway this could probably be configured there to avoid having to add bank specific blocks to the source code it self? |
Yeah, I think we need to allow the user control over the mapping between Nordigen and YNAB. I'm not sure how we should implement this yet. |
No bank seems to use the same Nordigen fields and the rudimentary best effort guess on which fields to use is not gonna float in the long term. This adds a structure for mapping every bank independently but defaults to using the Creditor/Debtor name mapping as that seems most common. Ref: #10
No bank seems to use the same Nordigen fields and the rudimentary best effort guess on which fields to use is not gonna float in the long term. This adds a structure for mapping every bank independently but defaults to using the Creditor/Debtor name mapping as that seems most common. BREAKING CHANGE: remove NORDIGEN_PAYEE_SOURCE config value in favor of static mappings based on NORDIGEN_BANKID value Ref: #10
@pfFredd if you share with me your banks ID (what you have in the NORDIGEN_BANKID environment variable) I can make a mapping for you that uses the additionalInformation field as payee. |
NORDIGEN_PAYEE_SOURCE=additionalInformatin (or perhaps just info) ? Would that work? I still have a hard time seeiing a situation where most of the fields would ever be interesting as the payee. We do need to do some stripping there though. At least for me, the additionalInformation is generally fairly long and contains too much information. |
@martinohansen That would be really kind of you! Thanks a lot. The NORDIGEN_BANKID is SEB_KORT_AB_NO_SKHSFI21 Let me know if you need anything else. |
I guess it boils down to whether there are a lot other banks using creative fields for providing the payee info, or if it is just a few.
I have looked through the transaction log for SEB_KORT_AB_NO_SKHSFI21, where Payee appeads in the additionalInformation property. It seems the payee info in this field gets trimmed to 22 characters. This said it probably makes sense to do some kind of stripping as other banks may provide a lot longer strings in that property. |
Support getting the payee from AdditionalInformation if its present in the Nordigen transaction and no creditor/debtor nor remittance information is available. Which is the case for SEB_KORT_AB_NO_SKHSFI21 for example. Fixes #10
Seems like every bank does it differently... maybe its a way for Nordigen to push their premium feature 🤷
We already strip the payee before sending to YNAB here: Lines 107 to 113 in 520a9dc
@pfFredd do you mind testing with this image to see if it works for you?
|
@martinohansen Just tested and it maps Payee correctly now, thanks! There seems to be an issue where Outflow and Inflow are swapped in YNAB, though. All purchases are listed as Inflow, and refunds appear as Outflow. |
Interesting 🤔 Do you mind opening another issue about it? |
Sure, no problem. I'll open a new issue for it. |
Hi,
Thanks for the great tool.
![image](https://user-images.githubusercontent.com/4218386/193852873-331c5bd5-a66e-4995-a693-d389de0e54ff.png)
However I only get transaction amount and with no data in memo its pretty hard to make sense of it
Is data from my bank structured in an unexpected way ?
How can I find out and patch ?
Thanks in advance for considering this issue :)
The text was updated successfully, but these errors were encountered: