Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement project builder #55

Merged
merged 1 commit into from
May 16, 2020
Merged

implement project builder #55

merged 1 commit into from
May 16, 2020

Conversation

martinohmann
Copy link
Owner

@martinohmann martinohmann commented May 15, 2020

This refactors the project creation logic to use the builder pattern because it allows for more flexibility when dealing with lots of arguments where most of them are optional.

@codecov-io
Copy link

codecov-io commented May 15, 2020

Codecov Report

Merging #55 into master will increase coverage by 1.80%.
The diff coverage is 92.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   73.67%   75.48%   +1.80%     
==========================================
  Files          25       25              
  Lines        1155     1175      +20     
==========================================
+ Hits          851      887      +36     
+ Misses        214      209       -5     
+ Partials       90       79      -11     
Impacted Files Coverage Δ
internal/skeleton/skeleton.go 65.11% <0.00%> (-4.89%) ⬇️
internal/project/builder.go 95.48% <95.48%> (ø)
internal/project/file.go 100.00% <100.00%> (ø)
internal/template/render.go 80.00% <100.00%> (+7.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f8795a...50a4427. Read the comment docs.

@martinohmann martinohmann force-pushed the project-builder branch 6 times, most recently from 61fec16 to bd6b9e4 Compare May 16, 2020 10:32
This refactors the project creation logic to use the builder pattern
because it allows for more flexibility when dealing with lots of
arguments where most of them are optional.
@martinohmann martinohmann changed the title WIP: project builder implement project builder May 16, 2020
@martinohmann martinohmann merged commit d09d15c into master May 16, 2020
@martinohmann martinohmann deleted the project-builder branch May 16, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants