macOS: Tab close button is on the wrong side

[phedlund]

Brief description of the issue.

Tab close buttons are placed on the right instead of the left side

How to reproduce the bug?

1. Open an article in a tab.
2. The close button is on the right side

What is the expected result?

On macOS close buttons are expected to be on the left side

What actually happened?

The close button is on the right side

Other information (logs, see Wiki)

[martinrotter]

Those buttons are drawn manually on the right side on all platforms, I will check what I can do.

[martinrotter]

Probably fixed, please check.

[phedlund]

Now drawn on the left, but there is an overlap between the favicon and the title. A fancy way of doing this would be to have the favicon turn into a close button when hovering over it with the mouse.

[martinrotter]

Oh, I see. I will check this out. Actually it is not totally bad idea to turn X icon into favicon if there is one. But it would make sense probably only on Mac OS X because on other platforms this Qt bug is not there, since X buttons are on the right side.

I believe that this is actually Qt bug, and not RSS Guard bug but I will check.

[martinrotter]

Yes, confirmed Qt bug - https://bugreports.qt.io/browse/QTBUG-61742?jql=text%20~%20%22tab%20icon%20button%22

It seems they have much trouble with icon/button/title of tab rendering.

Maybe. Could it "fix" the situation if the title of the tab would contain some spaces in its beginning? It would probably create some space between the icon and title.

[martinrotter]

Wait for c623da6 gets compiled and then please test, I added two spaces before tab title.

[martinrotter]

Confirm fixed pls.

[phedlund]

Yes, this fixes the overlap for now.

[martinrotter]

OK, I will close this. I also fixed the title for rest of use-cases (tab "Downloads") etc.