-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: Tab close button is on the wrong side #128
Comments
Those buttons are drawn manually on the right side on all platforms, I will check what I can do. |
Probably fixed, please check. |
Oh, I see. I will check this out. Actually it is not totally bad idea to turn X icon into favicon if there is one. But it would make sense probably only on Mac OS X because on other platforms this Qt bug is not there, since X buttons are on the right side. I believe that this is actually Qt bug, and not RSS Guard bug but I will check. |
Yes, confirmed Qt bug - https://bugreports.qt.io/browse/QTBUG-61742?jql=text%20~%20%22tab%20icon%20button%22 It seems they have much trouble with icon/button/title of tab rendering. Maybe. Could it "fix" the situation if the title of the tab would contain some spaces in its beginning? It would probably create some space between the icon and title. |
Wait for c623da6 gets compiled and then please test, I added two spaces before tab title. |
Confirm fixed pls. |
Yes, this fixes the overlap for now. |
OK, I will close this. I also fixed the title for rest of use-cases (tab "Downloads") etc. |
Brief description of the issue.
Tab close buttons are placed on the right instead of the left side
How to reproduce the bug?
What is the expected result?
On macOS close buttons are expected to be on the left side
What actually happened?
The close button is on the right side
Other information (logs, see Wiki)
The text was updated successfully, but these errors were encountered: