Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Regressions in version 4.7.0 #1416

Closed
danfe opened this issue May 23, 2024 · 11 comments
Closed

[BUG]: Regressions in version 4.7.0 #1416

danfe opened this issue May 23, 2024 · 11 comments
Assignees
Labels
Status-Fixed Ticket is resolved. Type-Defect This is BUG!!!
Milestone

Comments

@danfe
Copy link
Contributor

danfe commented May 23, 2024

After updating to the new version, all my feeds are gone and I'm greeted with an empty Add new account window.

Also, in the About window, version information is now just one long string with no separators.

Before (4.6.6):
466-ok

Now (4.7.0):
470-bad

Operating system and version

  • OS: FreeBSD/amd64
  • RSS Guard version: 4.7.0
@danfe danfe added the Type-Defect This is BUG!!! label May 23, 2024
@martinrotter
Copy link
Owner

Hi, this is amazing bug report. Where is the log showing some error? Where is precise set of steps to reproduce?

I personally have tested 4.7.0 from 4.6.6 updated several times, also using 4.7.0 for already many hours without problems.

Feel free to provide some context and relevant logs as at this point this BR is unusable.

@martinrotter martinrotter added Status-Needs-Help Someone else must provide better info, testing or PR. Status-Not-Enough-Data Ticket creator must append more precise info to the ticket. labels May 23, 2024
@martinrotter martinrotter reopened this May 23, 2024
@danfe
Copy link
Contributor Author

danfe commented May 23, 2024

Where is the log showing some error?

I don't see actual errors in the log, but for 4.7.0 its lacks several database: SQLite database connection '<something>' to file '/home/danfe/.config/RSS Guard 4/database/database.db' seems to be established and core: Custom ID of feed when loading from DB is 'n' debug messages, where <something> is various types of EntryPoints, followed by RecycleBin, ImportantNode, UnreadNode, LabelsNode, StandardServiceRoot, and n is from 1 to 4.

Where is precise set of steps to reproduce?

Just start the new version of the program and see your account and channels bar (the one on the left) empty. Close the program, reinstall 4.6.6, run it, see them back again.

I personally have tested 4.7.0 from 4.6.6 updated several times, also using 4.7.0 for already many hours without problems.

I see. Well, that's a bummer. I'll try to debug or bisect it and maybe get back to you with more information.

@martinrotter
Copy link
Owner

martinrotter commented May 27, 2024

It seems that perhaps library files with plugins are not loaded, provide full log from the point when you launch the app.

@martinrotter
Copy link
Owner

I will tast via ghostbsd

@martinrotter
Copy link
Owner

OK I tested it. While I found some other UNRELATED bugs, I must say that RSS Guard 4.7.0 works for me.

If "Add new account" window is empty, it means that library files with plugins were not loaded. So this is rather packaging problem.

I added semi-fix (not tested) to properly search for plugin library files on BSD.

https://github.com/martinrotter/rssguard/blob/master/src/librssguard/miscellaneous/pluginfactory.cpp#L68

Logic is this, if the main executable path in /xx/yy/rssguard (rssguard is name of binary), then rssguard searches plugin in path /xx/lib/rssguard/

So likely real directories should be like

"/usr/local/bin/rssguard" (executable)
"/urs/local/lib/rssguard/librssguard-standard.so" (plugin path)

Someone more able in BSD should check if latest [master] source code packages well.

@danfe
Copy link
Contributor Author

danfe commented May 27, 2024

So likely real directories should be like

"/usr/local/bin/rssguard" (executable)
"/urs/local/lib/rssguard/librssguard-standard.so" (plugin path)

Right, that matches my layout. There's also helpful message in the log now: core: Checking for plugins in '/usr/local/bin/..//rssguard' which suggests that the path was not constructed correctly for some reason (missing the lib part).

It turns out that you set RSSGUARD_LIBDIR="${CMAKE_INSTALL_LIBDIR}" before doing include (GNUInstallDirs). Moving that target_compile_definitions block after fixes the path and now everything's fine, my profile and feeds are all back and working!

@martinrotter
Copy link
Owner

Yes, the part "lib" seems to be missing, can you please do pull request with the fix you did? It would likely be best.

@chrisretusn
Copy link

chrisretusn commented May 27, 2024

I see the same issue.

slackware64-current.

RSS Guard

Version: 4.7.0 (built on Linux/x86_64)
Revision:
Build date: 5/27/24 1:00 PM
OS: Slackware 15.0 x86_64 (post 15.0 -current)
Qt: 6.7.1 (compiled against 6.7.1)

On starting rssguard from Konsole an empty "Add new account" window appears. The tray icon is in place, pressing Okay results in a segmentation fault. Pressing Cancel RSS Guard stays up, that's how I was able to copy the RSS Guard information. There are no feeds.

rssguard-20240527-Cancel.log
rssguard-20240527-Okay.log
rssguard-20240527.log

Reverting back to 4.6.6 and all is okay.

Note: This was my first build with qt6.

@chrisretusn
Copy link

Additional. The shared librariy fles are located as follows:

ls -l /usr/lib64/librssguard*.so /usr/lib64/rssguard/*
-rwxr-xr-x 1 root root 9319744 May 27 22:22 /usr/lib64/librssguard.so*
-rwxr-xr-x 1 root root 268336 May 27 22:22 /usr/lib64/rssguard/librssguard-feedly.so*
-rwxr-xr-x 1 root root 604976 May 27 22:22 /usr/lib64/rssguard/librssguard-gmail.so*
-rwxr-xr-x 1 root root 438512 May 27 22:22 /usr/lib64/rssguard/librssguard-greader.so*
-rwxr-xr-x 1 root root 239616 May 27 22:22 /usr/lib64/rssguard/librssguard-nextcloud.so*
-rwxr-xr-x 1 root root 909600 May 27 22:22 /usr/lib64/rssguard/librssguard-standard.so*
-rwxr-xr-x 1 root root 409312 May 27 22:22 /usr/lib64/rssguard/librssguard-ttrss.so*

@martinrotter
Copy link
Owner

Yes, these problems now should be basically fixed. Either as a packager wait for new release or try to repackage with latest [master] code.

@martinrotter martinrotter added this to the 4.7.1 milestone May 28, 2024
@martinrotter martinrotter added Status-Fixed Ticket is resolved. and removed Status-Needs-Help Someone else must provide better info, testing or PR. Status-Not-Enough-Data Ticket creator must append more precise info to the ticket. labels May 28, 2024
@chrisretusn
Copy link

Yes, these problems now should be basically fixed. Either as a packager wait for new release or try to repackage with latest [master] code.

I went with creating a package from master (523e760). All is well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status-Fixed Ticket is resolved. Type-Defect This is BUG!!!
Projects
None yet
Development

No branches or pull requests

3 participants