Non greedy #286
Merged
Non greedy #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this waiting on anything to merge? |
|
Sorry, I missed the notice. |
|
Hi, I don't understand this SW stack very well, but circumstantial evidence I see is that this change broke something. I use this for https://github.com/ietf-rats-wg/eat. It builds OK on MacOS with this, but the Circle CI build is broken. It also looks like Circle CI is broken here too. |
|
See #293 where we're tracking this one. I am equally in the dark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #285, but I'm not sure exactly how portable this is. Worth testing on some other platforms before merging, perhaps.