Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Add prev/next --conflict, which allows you to jump to the next conflict. #3248

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

PhilipMetzger
Copy link
Collaborator

@PhilipMetzger PhilipMetzger commented Mar 7, 2024

Tests are complete, although I need help there.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have added tests to cover my changes

@PhilipMetzger PhilipMetzger force-pushed the push-ntzqtqnuwrwy branch 2 times, most recently from d068fc8 to 46c0987 Compare April 29, 2024 19:31
@PhilipMetzger
Copy link
Collaborator Author

This is actually ready for review, I just need some help to finish the tests. I am seemingly unable to introduce the conflicts I want in my tests :-/.

@PhilipMetzger PhilipMetzger marked this pull request as ready for review April 29, 2024 19:33
@martinvonz
Copy link
Owner

I am seemingly unable to introduce the conflicts I want in my tests :-/.

What do you need help with? Did you try searching the tests for "conflict"? Are you looking for something different?

cli/src/commands/next.rs Outdated Show resolved Hide resolved
@PhilipMetzger PhilipMetzger force-pushed the push-ntzqtqnuwrwy branch 4 times, most recently from 7ee55c8 to ce831db Compare May 12, 2024 20:35
lib/src/revset.rs Outdated Show resolved Hide resolved
lib/src/revset.rs Show resolved Hide resolved
lib/src/revset.rs Outdated Show resolved Hide resolved
lib/src/revset.rs Outdated Show resolved Hide resolved
lib/src/revset.rs Show resolved Hide resolved
cli/tests/test_next_prev_commands.rs Show resolved Hide resolved
cli/tests/test_next_prev_commands.rs Show resolved Hide resolved
cli/tests/test_next_prev_commands.rs Outdated Show resolved Hide resolved
cli/tests/test_next_prev_commands.rs Show resolved Hide resolved
cli/tests/test_next_prev_commands.rs Outdated Show resolved Hide resolved
@PhilipMetzger PhilipMetzger force-pushed the push-ntzqtqnuwrwy branch 3 times, most recently from 10ea3dc to 1ed88b1 Compare May 18, 2024 16:34
cli/src/commands/next.rs Show resolved Hide resolved
cli/tests/test_next_prev_commands.rs Show resolved Hide resolved
cli/tests/test_next_prev_commands.rs Show resolved Hide resolved
cli/tests/test_next_prev_commands.rs Outdated Show resolved Hide resolved
cli/tests/test_next_prev_commands.rs Outdated Show resolved Hide resolved
cli/tests/test_next_prev_commands.rs Outdated Show resolved Hide resolved
cli/tests/test_next_prev_commands.rs Outdated Show resolved Hide resolved
cli/src/commands/prev.rs Outdated Show resolved Hide resolved
cli/tests/test_next_prev_commands.rs Show resolved Hide resolved
cli/tests/test_next_prev_commands.rs Outdated Show resolved Hide resolved
cli/tests/test_next_prev_commands.rs Show resolved Hide resolved
cli/tests/test_next_prev_commands.rs Outdated Show resolved Hide resolved
@PhilipMetzger
Copy link
Collaborator Author

After thinking a bit on during my holiday, I'm fine with either version. I'd like to land this ASAP though, so I can finally spend my owed time to run.

@PhilipMetzger PhilipMetzger force-pushed the push-ntzqtqnuwrwy branch 2 times, most recently from 64d4856 to e2a0017 Compare June 20, 2024 17:00
PhilipMetzger and others added 2 commits June 20, 2024 19:12
This allows users to easily filter a commit range by conflicts, which will be needed for `next/prev`
further down in the next commit. Users which benefit from it were also migrated.
This allows users to jump to the next conflict in the ancestors or children of 
the start commit.

Continues work on #2126

Co-Authored-By: Noah Mayr <dev@noahmayr.com>
@PhilipMetzger PhilipMetzger enabled auto-merge (rebase) June 20, 2024 17:12
@PhilipMetzger PhilipMetzger merged commit de022ae into main Jun 20, 2024
29 checks passed
@PhilipMetzger PhilipMetzger deleted the push-ntzqtqnuwrwy branch June 20, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants