Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to control extension of CSS Modules. #14

Open
YurySolovyov opened this issue May 19, 2021 · 4 comments
Open

A way to control extension of CSS Modules. #14

YurySolovyov opened this issue May 19, 2021 · 4 comments

Comments

@YurySolovyov
Copy link

Right now there is no way to control how the plugin decides if a file should be treated as a module, cause regexp for that is hard-coded as /\.module/.
If I want to use any of my css/sass files as a module, I have to name them all as *.module.css.
Do you think we can make this configurable?

@martonlederer
Copy link
Owner

This is the standard for CSS modules, but if you want to, create a PR with a custom option. Just make sure the default one is .module

@gsouf
Copy link
Contributor

gsouf commented Dec 27, 2021

@martonlederer not all apps use this standard, so even though this is the standard I don't think it hurts to make it configurable. Does it?

@martonlederer
Copy link
Owner

As I said, I have no problems with making it configurable

Just make sure the default one is .module

gsouf added a commit to gsouf/esbuild-plugin-postcss2 that referenced this issue Dec 27, 2021
gsouf added a commit to gsouf/esbuild-plugin-postcss2 that referenced this issue Dec 27, 2021
gsouf added a commit to gsouf/esbuild-plugin-postcss2 that referenced this issue Dec 27, 2021
gsouf added a commit to gsouf/esbuild-plugin-postcss2 that referenced this issue Dec 27, 2021
gsouf added a commit to gsouf/esbuild-plugin-postcss2 that referenced this issue Dec 27, 2021
gsouf added a commit to gsouf/esbuild-plugin-postcss2 that referenced this issue Dec 27, 2021
gsouf added a commit to gsouf/esbuild-plugin-postcss2 that referenced this issue Dec 27, 2021
@gsouf
Copy link
Contributor

gsouf commented Dec 27, 2021

@martonlederer sorry my bad I did read your message too quickly. Here is a PR for it #34

martonlederer added a commit that referenced this issue Feb 1, 2022
make module file configurable #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants