This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
Python port of Nailgun client #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhamiltoncx
force-pushed
the
nailgun-client-py
branch
4 times, most recently
from
974c267
to
ec7826d
Compare
We have a lot of Buck users who struggle to compile the native Nailgun C client. This ports the client to pure Python instead. I tested this with the Buck Nailgun server on Linux 3.10.75 with Python 2.6 and OS X 10.10.4 with Python 2.7. This client doesn't yet work on Windows, since Python `select.select()` doesn't handle a mix of sockets and file handles on Windows.
bhamiltoncx
force-pushed
the
nailgun-client-py
branch
from
ec7826d
to
0fd2dd4
Compare
jimpurbrick
added a commit
that referenced
this pull request
Nov 12, 2015
Python port of Nailgun client
bhamiltoncx
added a commit
to facebook/buck
that referenced
this pull request
Nov 16, 2015
Summary: We've constantly struggled with building the native Nailgun C client as part of distributing Buck. Adding the requirement of a C compiler is a lot to ask for people building pure Java projects. We often run into users who have to deal with things like accepting Xcode license agreements as root just to build Buck, which seems silly. This diff adds a pure Python port of the Nailgun client so we can distribute a pure Java distribution of Buck that works with `buckd`. I made sure the Python code worked both with Python 2.6 and 2.7. This doesn't yet work on Windows, but we don't support `buckd` on Windows yet, so it's not a net loss of functionality. I sent this pull request upstream as well: facebookarchive/nailgun#80 Test Plan: Tested on Linux 3.10.75 with Python 2.6 and OS X 10.10.4 with Python 2.7. Started `buckd` with `buck build buck`. Connected Python client and built again by running: python third-party/nailgun/nailgun-client/ng.py --nailgun-server=local:.buckd/sock com.facebook.buck.cli.Main build buck
shs96c
pushed a commit
to shs96c/buck
that referenced
this pull request
Dec 26, 2015
Summary: We've constantly struggled with building the native Nailgun C client as part of distributing Buck. Adding the requirement of a C compiler is a lot to ask for people building pure Java projects. We often run into users who have to deal with things like accepting Xcode license agreements as root just to build Buck, which seems silly. This diff adds a pure Python port of the Nailgun client so we can distribute a pure Java distribution of Buck that works with `buckd`. I made sure the Python code worked both with Python 2.6 and 2.7. This doesn't yet work on Windows, but we don't support `buckd` on Windows yet, so it's not a net loss of functionality. I sent this pull request upstream as well: facebookarchive/nailgun#80 Test Plan: Tested on Linux 3.10.75 with Python 2.6 and OS X 10.10.4 with Python 2.7. Started `buckd` with `buck build buck`. Connected Python client and built again by running: python third-party/nailgun/nailgun-client/ng.py --nailgun-server=local:.buckd/sock com.facebook.buck.cli.Main build buck
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of Buck users who struggle to compile the native Nailgun C client.
This ports the client to pure Python instead. I tested this with the Buck
Nailgun server on Linux 3.10.75 with Python 2.6 and OS X 10.10.4 with Python 2.7.
This client doesn't yet work on Windows, since Python
select.select()doesn'thandle a mix of sockets and file handles on Windows.