Colons in user messages cause issues #122
Comments
Pumpuli
added a commit
to Pumpuli/node-irc
that referenced
this issue
Nov 14, 2012
|
One minor problem remains with the fix in c1659f9 - messages that begin with a colon. E.g. |
|
Not sure if this is causing you guys problems but that regex doesn't seem to completely fix it for me? It still prepends the : infront of the message. Heres a fix i've proposed without the need for using more regex calls in the parsing method too. #128 |
quentinxs
added a commit
to quentinxs/node-irc
that referenced
this issue
Jan 19, 2013
This fixes issues martynsmith#122, martynsmith#128 and martynsmith#133. Example lines include: :some.irc.net 324 webuser #channel +Cnj 5:10 :nick!user@host QUIT :Ping timeout: 252 seconds :nick!user@host PRIVMSG #channel :so : colons: :are :: not a problem ::::
|
Didn't af6f07f fix this as well? |
uiur
pushed a commit
to uiur/node-irc
that referenced
this issue
Feb 2, 2013
This fixes issues martynsmith#122, martynsmith#128 and martynsmith#133. Example lines include: :some.irc.net 324 webuser #channel +Cnj 5:10 :nick!user@host QUIT :Ping timeout: 252 seconds :nick!user@host PRIVMSG #channel :so : colons: :are :: not a problem ::::
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Causes thedjpetersen/subway#174
Problem code seems to be here: https://github.com/martynsmith/node-irc/blob/master/lib/irc.js#L875-882
The regex is apparently not robust enough to fully handle colon characters in a multi-word message. Emoticons in particular are a problem.
A message like:
What's up? :)is sent to node-irc Client listeners as:
:What'sI'd attempt to provide a corrected regex, but I'm not that knowledgeable on the IRC protocol and would probably break this logic for input that is currently handled correctly.
The text was updated successfully, but these errors were encountered: