Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misuse of unbuffered os.Signal channel as argument to signal.Notify #63

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

nvanbenschoten
Copy link
Contributor

This addresses a new vet warning added in Go 1.17.

See https://golang.org/doc/go1.17#vet.

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #63 (e86b0f4) into main (f6bdb73) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main     #63     +/-   ##
=======================================
+ Coverage   90.0%   90.1%   +0.1%     
=======================================
  Files         12      12             
  Lines       3471    3471             
=======================================
+ Hits        3124    3126      +2     
+ Misses       282     281      -1     
+ Partials      65      64      -1     
Impacted Files Coverage Δ
internal/main.go 40.9% <100.0%> (ø)
stack/stack.go 85.2% <0.0%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6bdb73...e86b0f4. Read the comment docs.

@maruel
Copy link
Owner

maruel commented Sep 7, 2021

Thanks!

@maruel maruel merged commit 98fd2ed into maruel:main Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants