pp: Don't silence os.Interrupt signal #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no benefit to doing so, let's remove it.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
=====================================
Coverage 83.4% 83.4%
=====================================
Files 12 12
Lines 2768 2768
=====================================
Hits 2308 2308
Misses 399 399
Partials 61 61
☔ View full report in Codecov by Sentry. |
|
It is intentional. |
|
Why?
…On Mon, Jul 3, 2023 at 1:58 PM M-A ***@***.***> wrote:
It is intentional.
—
Reply to this email directly, view it on GitHub
<#86 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABA7M4UY5Y3ITGEOO3X6S3XOMB3LANCNFSM6AAAAAAZ4XQ654>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
The user can Ctrl-C out a test, so Ctrl-C out of |
|
What's the situation where this is useful? If I need to ^C the test, then
there's no panic. If there is a panic, then the test has exited so it
doesn't need ^C.
…On Mon, Jul 3, 2023 at 2:03 PM M-A ***@***.***> wrote:
The user can Ctrl-C out a test, so Ctrl-C out of go test |& pp does the
right thing.
—
Reply to this email directly, view it on GitHub
<#86 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABA7M6HMTAUFKFL62RVD23XOMCM5ANCNFSM6AAAAAAZ4XQ654>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no benefit to doing so, let's remove it.