Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature tests #8

Merged
merged 7 commits into from
Oct 2, 2023
Merged

Feature tests #8

merged 7 commits into from
Oct 2, 2023

Conversation

AnsarIbrahim
Copy link
Collaborator

@AnsarIbrahim AnsarIbrahim commented Oct 2, 2023

In this branch:

  • We fixed the N+1 problem is solved when fetching all posts and their comments for a user

Screenshot before the fix

before

Screenshot after the fix

after

-We added integration specs for:

  1. User index page:
    We can see the username of all other users.
    We can see the profile picture for each user.
    We can see the number of posts each user has written.
    When we click on a user, I am redirected to that user's show page.
  2. User show page:
    We can see the user's profile picture.
    We can see the user's username.
    We can see the number of posts the user has written.
    We can see the user's bio.
    We can see the user's first 3 posts.
    We can see a button that lets me view all of a user's posts.
    When click a user's post, it redirects me to that post's show page.
    When click to see all posts, it redirects me to the user's post's index page.
  3. User post index page:
    We can see the user's profile picture.
    We can see the user's username.
    We can see the number of posts the user has written.
    We can see a post's title.
    We can see some of the post's body.
    We can see the first comments on a post.
    We can see how many comments a post has.
    We can see how many likes a post has.
    We can see a section for pagination if there are more posts than fit on the view.
    When click on a post, it redirects me to that post's show page.
  4. Post show page:
    We can see the post's title.
    We can see who wrote the post.
    We can see how many comments it has.
    We can see how many likes it has.
    We can see the post body.
    We can see the username of each commenter.
    We can see the comment each commentor left.

Let us know of any changes required @AnsarIbrahim @marvin-nyalik

Copy link

@Abenezer-Tilahun Abenezer-Tilahun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AnsarIbrahim @marvin-nyalik

Your project is complete 👍 💯 There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights 👏🏻

✔️ No linter errors.
✔️ You used correct Git-Flow.
✔️ Professional README
✔️ Good Commit Messages.
✔️ Correctly Solved N+1 problem when fetching all posts and their comments for a user.
✔️ Correctly include integration specs for User index page and user show page.
✔️ Correctly include integration specs for User Post index page and post show page.
✔️ Good job for Implemented Blog app - integration specs for views and fix n+1 problems.
✔️ All Test cases are passing.

test cases

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

@marvin-nyalik marvin-nyalik merged commit ba9a37f into dev Oct 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants