Should use String or Int for BigDecimal value #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should use string and not double or float when constructing a BigDecimal to prevent floating point errors from getting introduced.
Or use a long or int combined with a decimal shift operation: new BigDecimal("1.001") or new BigDecimal(1001).movePointLeft(3);
|
Thanks @michael-newsrx - Really appretiate that =) Do you plan to submit this pull request through utopian or can I leave it open for 1-2 days as a reminder to check if I have made this mistake in some other places? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should use string and not double or float when constructing a BigDecimal to prevent floating point errors from getting introduced.
Or use a long or int combined with a decimal shift operation: new BigDecimal("1.001") or new BigDecimal(1001).movePointLeft(3);