Make CVise understand files in a filesystem tree #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CVise now understands test cases that live in subdirectories in a filesystem tree. The behaviour is to simply create the directories needed in tmpfs. And interestingness checks are already expected to handle paths to test cases. For example, a user can now say: cvise <args> ./interesting.sh dir1/file1 file2 dir2/file1 dir3/file3 This feature ought to make it easier to minimise more complicated situations involving larger applications that create complex out-of-source build trees where: 1. there are several files in different directories; and 2. files that have the same name but live in different directories.
|
Thanks for the pull request. I decided to use this opportunity and make a bigger refactoring related to |
Thank you.
Will do. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVise now understands test cases that live in subdirectories in a filesystem tree.
The behaviour is to simply create the directories needed in tmpfs. And interestingness checks are already expected to handle paths to test cases.
For example, a user can now say:
cvise <args> ./interesting.sh dir1/file1 file2 dir2/file1 dir3/file3This feature ought to make it easier to minimise more complicated situations involving larger applications that create complex out-of-source build trees where:
There is some extra historical context behind this pull request. I had initially made an inquiry about copying extra folders in #110. In that issue, however, CVise didn't really understand that the directory is really part of the test case. What I'm trying to do here is give the user the opportunity to minimise test cases without having to extract them all from an existing and potentially complex directory hierarchy.
I'm very open to criticism on this contribution, so please feel free to tear it apart. Or if this contribution isn't something that the community is interested in, I'm happy for it to be rejected.