Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CVise understand files in a filesystem tree #133

Merged
merged 4 commits into from
Apr 14, 2024
Merged

Conversation

marxin
Copy link
Owner

@marxin marxin commented Apr 14, 2024

Implements: #110

marxin and others added 2 commits April 14, 2024 17:43
CVise now understands test cases that live in subdirectories in a
filesystem tree.

The behaviour is to simply create the directories needed in tmpfs.
And interestingness checks are already expected to handle paths to
test cases.

For example, a user can now say:

cvise <args> ./interesting.sh dir1/file1 file2 dir2/file1 dir3/file3

This feature ought to make it easier to minimise more complicated
situations involving larger applications that create complex
out-of-source build trees where:

1. there are several files in different directories; and
2. files that have the same name but live in different directories.

Co-Authored-By: dmcdougall <mail@dmcdougall.co.uk>
@dmcdougall
Copy link
Contributor

I tried out the branch. In the admittedly very simple test case I was trying out, I seem to get the intended behaviour. I haven't tried it out on a very complex codebase yet.

Thanks so much for co-author attribution on the commit. Appreciate that.

@marxin
Copy link
Owner Author

marxin commented Apr 14, 2024

Thanks for the idea and the pull request.

Please test it thoroughly (if you have a change) once it's merged into the master branch.

@marxin marxin merged commit 98f5038 into master Apr 14, 2024
12 checks passed
@marxin marxin deleted the pathlib-refactoring branch April 14, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants