Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App ID should be UInt64 instead of Int #478

Open
1 task done
algorythmic opened this issue Nov 1, 2022 · 0 comments · May be fixed by #535
Open
1 task done

App ID should be UInt64 instead of Int #478

algorythmic opened this issue Nov 1, 2022 · 0 comments · May be fixed by #535
Assignees
Labels
Milestone

Comments

@algorythmic
Copy link

Your Environment

  • mas version: 1.8.6
  • macOS version (system_profiler SPSoftwareDataType -detailLevel mini): 13.0 (22A380)

mas Install Method

  • brew install mas (homebrew-core)

Describe the Bug

The App ID reported in mas search output is incorrect if the ID is a number larger than Int32.max.

To Reproduce

Search for a term that includes results with a high App ID.

Expected Behavior

mas search KeepPass
...
  6443922649  KeepPass Password Manager      (1.1)
...

Actual Behavior

mas search KeepPass
...
 -2146011943  KeepPass Password Manager      (1.1)
...
xyzzy-plugh-plover added a commit to xyzzy-plugh-plover/mas that referenced this issue Sep 11, 2024
Supersede mas-cli#479
Fix mas-cli#478

Signed-off-by: xyzzy-plugh-plover <114089973+xyzzy-plugh-plover@users.noreply.github.com>
@xyzzy-plugh-plover xyzzy-plugh-plover linked a pull request Sep 11, 2024 that will close this issue
@rgoldberg rgoldberg changed the title 🐛 [BUG] App ID integer type confusion in search results App ID should be UInt64 instead of Int Sep 14, 2024
@rgoldberg rgoldberg added this to the 1.8.7 milestone Sep 15, 2024
@rgoldberg rgoldberg self-assigned this Sep 16, 2024
rgoldberg pushed a commit to xyzzy-plugh-plover/mas that referenced this issue Oct 6, 2024
Supersede mas-cli#479
Fix mas-cli#478

Signed-off-by: xyzzy-plugh-plover <114089973+xyzzy-plugh-plover@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants